[GitHub] sxjscience opened a new pull request #12446: [Bugfix] Fix flaky topk

[GitBox <gi...@apache.org>]

sxjscience opened a new pull request #12446: [Bugfix] Fix flaky topk
URL: https://github.com/apache/incubator-mxnet/pull/12446
 
 
   ## Description ##
   This PR fixes the flaky topk test. The previous bug is caused by not manually set the dtype of mx.ndarrays when constructing it from a numpy ndarray (related issue: https://github.com/apache/incubator-mxnet/issues/12268). After reimplementing the `IndexFill` function, the test passes now.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] fix topk and its testing codes.
   
   
   ## Comments ##
   - we really need to fix https://github.com/apache/incubator-mxnet/issues/12268.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services