You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/05/09 08:37:50 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #20270: [improve][build] Upgrade maven surefire plugin and other build/test plugins/libs including TestNG version

lhotari opened a new pull request, #20270:
URL: https://github.com/apache/pulsar/pull/20270

   ### Motivation & Modifications
   
   - get rid of some warnings in maven 3.9.x
   - upgrade Maven surefire to a stable version
     - Pulsar was stuck on Maven surefire version 3.0.0-M3 for a very long time
   - upgrade other build/test related plugins
   - upgrade Gradle Enterprise maven extension to 1.17.1
   - upgrade TestNG version to 7.7.1
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #20270: [improve][build] Upgrade maven surefire plugin and other build/test plugins/libs including TestNG version

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20270:
URL: https://github.com/apache/pulsar/pull/20270#issuecomment-1540970981

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#20270](https://app.codecov.io/gh/apache/pulsar/pull/20270?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ba7167) into [master](https://app.codecov.io/gh/apache/pulsar/commit/00f17e88ad8fa9a4ead78d78a181c03fdee8e4df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00f17e8) will **increase** coverage by `35.32%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/20270/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://app.codecov.io/gh/apache/pulsar/pull/20270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #20270       +/-   ##
   =============================================
   + Coverage     37.61%   72.93%   +35.32%     
   - Complexity    12589    31956    +19367     
   =============================================
     Files          1691     1868      +177     
     Lines        129028   138586     +9558     
     Branches      14066    15236     +1170     
   =============================================
   + Hits          48530   101074    +52544     
   + Misses        74183    29471    -44712     
   - Partials       6315     8041     +1726     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | inttests | `24.17% <ø> (ø)` | |
   | systests | `24.92% <ø> (+0.15%)` | :arrow_up: |
   | unittests | `72.20% <ø> (+39.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 1427 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20270/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari merged pull request #20270: [improve][build] Upgrade maven surefire plugin and other build/test plugins/libs including TestNG version

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #20270:
URL: https://github.com/apache/pulsar/pull/20270


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #20270: [improve][build] Upgrade maven surefire plugin and other build/test plugins/libs including TestNG version

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20270:
URL: https://github.com/apache/pulsar/pull/20270#issuecomment-1539692933

   @lhotari Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #20270: [improve][build] Upgrade maven surefire plugin and other build/test plugins/libs including TestNG version

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20270:
URL: https://github.com/apache/pulsar/pull/20270#issuecomment-1540851866

   /pulsarbot rerun-failure-checks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org