You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/05/24 08:10:13 UTC

[GitHub] [iotdb] Alima777 commented on a change in pull request #3219: add query last data interface

Alima777 commented on a change in pull request #3219:
URL: https://github.com/apache/iotdb/pull/3219#discussion_r637760212



##########
File path: thrift/src/main/thrift/rpc.thrift
##########
@@ -291,6 +291,16 @@ struct TSRawDataQueryReq {
   7: optional bool enableRedirectQuery;
 }
 
+struct TSLastDataQueryReq {
+  1: required i64 sessionId
+  2: required list<string> suffixPath
+  3: required list<string> prefixPath

Review comment:
       Just give the complete path, now that we use session, we don't need to concat the path again.

##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -589,6 +589,48 @@ public SessionDataSet executeRawDataQuery(List<String> paths, long startTime, lo
     }
   }
 
+  /**
+   * only: select last status from root.ln.wf01.wt01 where time >= 1621326244168; must satisfy
+   * <PrefixPath> + <suffixPath> = <TimeSeries>
+   *
+   * @param suffixPath the timeSeries suffix. eg. root.ln.wf01.wt01
+   * @param prefixPath the timeSeries prefix. eg. status
+   * @param LastTime get the last data,whose timestamp greater than or equal LastTime eg.
+   *     1621326244168

Review comment:
       ```suggestion
      * @param LastTime get the last data, whose timestamp greater than or equal LastTime eg.
      *     1621326244168
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org