You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/29 17:20:31 UTC
[GitHub] [accumulo] Umang228 opened a new pull request #2051: Update SingletonManager.java
Umang228 opened a new pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051
Renamed method in SingletonManager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Umang228 commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
Umang228 commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-830012526
Accumulo start is a folder . The files in the folder are giving error in checks. And my IDE showing everything right (no errors).
Java -> version 13 , Maven -> version 3.8, command -> mvn clean verify -DskipITs ...... Plz help asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829492523
No worries - hopefully this is a good learning experience. This is one reason I keep suggesting that you build locally - once you can do that then you are better positioned for future contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] billierinaldi commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
billierinaldi commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829456417
> But there is only one rerservation which I corrected and rest are correct
@Umang228 The method is called from one other class, see [SingletonReservation.java](https://github.com/apache/accumulo/blob/f9bc91405ea4fb166d50d28a26d438265af5b554/core/src/main/java/org/apache/accumulo/core/singletons/SingletonReservation.java#L50)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Umang228 commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
Umang228 commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829496275
I dont know how to do locally. plz suggest me a guide ( video or steps ) to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-830662369
Superseded by #2061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-830021175
Assuming that by your drive name - this is windows? The file that is trying to execute is a linux bash script. I'm not sure that Accumulo will build on windows - do you have access linux vm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] brianloss commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
brianloss commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-830023692
Yeah, I don't believe building on Windows is supported. I think you can try a cygwin or possible WSL environment, but little or no testing has been done with either of those as far as I am aware. If you have or can install Docker, then you could try building from a Docker container. Something like [maven](https://hub.docker.com/_/maven) would probably work if you volume mount your source directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Umang228 commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
Umang228 commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829932767
Bro.... Accumulo start is failed to run . There are no errors in the file and also I didnt changed anything in start still its failed to run.
org.codehaus.mojo:exec-maven-plugin:3.0.0:exec this is not executing. Plz help..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829960839
I do not understand what you mean by Accumulo start. Please provide the commands that you are using, your java , maven and os versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Umang228 closed pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
Umang228 closed pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-830026285
If you have access to slack, you can sign up to the Accumulo channel using info provided here: https://accumulo.apache.org/contact-us/ - that might be easier for help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Umang228 commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
Umang228 commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-830019400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Umang228 commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
Umang228 commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-830023472
yes I have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829456166
The QA build failed with a compilation error - symbol not found. When you changed the name of the method, you also need to update all references to that name to the updated name - and those can be in other files. If you compile locally, the failure will tell you the files that need to be modified, or you can use the find references in your ide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Umang228 commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
Umang228 commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829466032
Sorry for that. Give me some time I messed up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] brianloss edited a comment on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
brianloss edited a comment on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-830023692
Yeah, I don't believe building on Windows is supported. I think you can try a cygwin or possibly WSL environment, but little or no testing has been done with either of those as far as I am aware. If you have or can install Docker, then you could try building from a Docker container. Something like [maven](https://hub.docker.com/_/maven) would probably work if you volume mount your source directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] Umang228 commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
Umang228 commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829453124
But there is only one rerservation which I corrected and rest are correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829462750
The QA tests still failed - this cannot be merged until you can get a clean run. Please verify locally before updating the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on pull request #2051: Update SingletonManager.java
Posted by GitBox <gi...@apache.org>.
EdColeman commented on pull request #2051:
URL: https://github.com/apache/accumulo/pull/2051#issuecomment-829500556
See https://accumulo.apache.org/how-to-contribute/#example-contribution-workflow But basically run
`mvn clean verify -DskipITs`
and get a clean build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org