You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2018/08/30 18:49:56 UTC
Review Request 68572: RANGER-2204: Ranger Admin's admin log event for
changing Audit Logging of a policy doesn't show the actual changes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68572/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-2204
https://issues.apache.org/jira/browse/RANGER-2204
Repository: ranger
Description
-------
Fixed issue where audit log values for policy service are not processed properly while getting the transaction logs.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ad3984d28
Diff: https://reviews.apache.org/r/68572/diff/1/
Testing
-------
1. Verfied the existing unit tests are working fine
2. Also verified the changes patched on a cluster and see the audits are written properly
Thanks,
Sailaja Polavarapu
Re: Review Request 68572: RANGER-2204: Ranger Admin's admin log event
for changing Audit Logging of a policy doesn't show the actual changes
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68572/#review208146
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java
Lines 248 (patched)
<https://reviews.apache.org/r/68572/#comment291927>
String.valueOf is redundant. It already done in processIsAuditEnabledClassFieldNameForTrxLog() or check if we need to have method. processIsAuditEnabledClassFieldNameForTrxLog().
Please check in all occurance
- Ramesh Mani
On Aug. 30, 2018, 6:49 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68572/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 6:49 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2204
> https://issues.apache.org/jira/browse/RANGER-2204
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed issue where audit log values for policy service are not processed properly while getting the transaction logs.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ad3984d28
>
>
> Diff: https://reviews.apache.org/r/68572/diff/1/
>
>
> Testing
> -------
>
> 1. Verfied the existing unit tests are working fine
> 2. Also verified the changes patched on a cluster and see the audits are written properly
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 68572: RANGER-2204: Ranger Admin's admin log event
for changing Audit Logging of a policy doesn't show the actual changes
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68572/#review208153
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On Aug. 30, 2018, 10:05 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68572/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 10:05 p.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-2204
> https://issues.apache.org/jira/browse/RANGER-2204
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed issue where audit log values for policy service are not processed properly while getting the transaction logs.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ad3984d28
>
>
> Diff: https://reviews.apache.org/r/68572/diff/2/
>
>
> Testing
> -------
>
> 1. Verfied the existing unit tests are working fine
> 2. Also verified the changes patched on a cluster and see the audits are written properly
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 68572: RANGER-2204: Ranger Admin's admin log event
for changing Audit Logging of a policy doesn't show the actual changes
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68572/
-----------------------------------------------------------
(Updated Aug. 30, 2018, 10:05 p.m.)
Review request for ranger.
Changes
-------
Incorporated review comments
Bugs: RANGER-2204
https://issues.apache.org/jira/browse/RANGER-2204
Repository: ranger
Description
-------
Fixed issue where audit log values for policy service are not processed properly while getting the transaction logs.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java ad3984d28
Diff: https://reviews.apache.org/r/68572/diff/2/
Changes: https://reviews.apache.org/r/68572/diff/1-2/
Testing
-------
1. Verfied the existing unit tests are working fine
2. Also verified the changes patched on a cluster and see the audits are written properly
Thanks,
Sailaja Polavarapu