You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/20 15:09:39 UTC

[GitHub] [incubator-kyuubi] bowenliang123 commented on a diff in pull request #3288: [KYUUBI #3222][FOLLOWUP] Fixing placeholder and config with user keyword for JDBC Authentication Provider

bowenliang123 commented on code in PR #3288:
URL: https://github.com/apache/incubator-kyuubi/pull/3288#discussion_r950705630


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/util/JdbcUtils.scala:
##########
@@ -95,4 +97,11 @@ object JdbcUtils extends Logging {
       }
     }
   }
+
+  def redactPassword(password: Option[String]): String = {

Review Comment:
   @pan3793 I moved move redactPassword method to JdbcUtils. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org