You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/11 00:54:35 UTC
[GitHub] [arrow-datafusion] liukun4515 opened a new issue #1545: decimal support for agg function
liukun4515 opened a new issue #1545:
URL: https://github.com/apache/arrow-datafusion/issues/1545
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
The decimal data type has been supported in #122, but in this issue #122 we just support several agg functions.
In this issue we will list some functions which are not implemented for the decimal data type.
- [ ] sum https://github.com/apache/arrow-datafusion/pull/1408
- [ ] min/max https://github.com/apache/arrow-datafusion/pull/1407
- [ ] count/DistinctCount: don't need to implement
- [ ] avg https://github.com/apache/arrow-datafusion/pull/1408
- [ ] var(col1): calculate the variance (sample) of col1
- [ ] var_samp(col1): calculate the variance (sample) of col1
- [ ] var_pop(col1): calculate the variance (population) of col1
- [ ] stddev(col1): calculate the standard deviation (sample) of col1
- [ ] stddev_samp(col1): calculate the standard deviation (sample) of col1
- [ ] stddev_pop(col1): calculate the standard deviation (population) of col1
TODO
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] realno commented on issue #1545: decimal support for agg function
Posted by GitBox <gi...@apache.org>.
realno commented on issue #1545:
URL: https://github.com/apache/arrow-datafusion/issues/1545#issuecomment-1010709371
@liukun4515 I have added more functions and am planning to add a few in the next few days. Here are the list, please add as tasks:
covar(col1, col2): calculate the covariance (sample) of col1 and col2
covar_samp(col1, col2): calculate the covariance (sample) of col1 and col2
covar_pop(col1, col2): calculate the covariance (population) of col1 and col2
corr(col1, col2): calculate the correlation coefficient (sample) of col1 and col2
corr_samp(col1, col2): calculate the correlation coefficient (sample) of col1 and col2
corr_pop(col1, col2): calculate the correlation coefficient (population) of col1 and col2
median(col1): calculate the median of col1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #1545: decimal support for agg function
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1545:
URL: https://github.com/apache/arrow-datafusion/issues/1545#issuecomment-1011570170
> e next few da
thanks @realno , I will add them.
You can add the agg functions first, the decimal supporting is not an emergency work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #1545: decimal support for agg function
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1545:
URL: https://github.com/apache/arrow-datafusion/issues/1545#issuecomment-1010726661
> @liukun4515 I have added more functions and am planning to add a few in the next few days. Here are the list, please add as tasks:
>
> covar(col1, col2): calculate the covariance (sample) of col1 and col2
>
> covar_samp(col1, col2): calculate the covariance (sample) of col1 and col2
>
> covar_pop(col1, col2): calculate the covariance (population) of col1 and col2
>
> corr(col1, col2): calculate the correlation coefficient (sample) of col1 and col2
>
> corr_samp(col1, col2): calculate the correlation coefficient (sample) of col1 and col2
>
> corr_pop(col1, col2): calculate the correlation coefficient (population) of col1 and col2
>
> median(col1): calculate the median of col1
@realno The list of function are not agg function, and they are the builtin-function for datafusion.
Now the decimal is not supported in the builtin-function.
I will support them with decimal data when refactoring this model.
I will file a new issue to track builtin-function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 removed a comment on issue #1545: decimal support for agg function
Posted by GitBox <gi...@apache.org>.
liukun4515 removed a comment on issue #1545:
URL: https://github.com/apache/arrow-datafusion/issues/1545#issuecomment-1010726661
> @liukun4515 I have added more functions and am planning to add a few in the next few days. Here are the list, please add as tasks:
>
> covar(col1, col2): calculate the covariance (sample) of col1 and col2
>
> covar_samp(col1, col2): calculate the covariance (sample) of col1 and col2
>
> covar_pop(col1, col2): calculate the covariance (population) of col1 and col2
>
> corr(col1, col2): calculate the correlation coefficient (sample) of col1 and col2
>
> corr_samp(col1, col2): calculate the correlation coefficient (sample) of col1 and col2
>
> corr_pop(col1, col2): calculate the correlation coefficient (population) of col1 and col2
>
> median(col1): calculate the median of col1
@realno The list of function are not agg function, and they are the builtin-function for datafusion.
Now the decimal is not supported in the builtin-function.
I will support them with decimal data when refactoring this model.
I will file a new issue to track builtin-function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #1545: decimal support for agg function
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1545:
URL: https://github.com/apache/arrow-datafusion/issues/1545#issuecomment-1009495696
@realno I add this issue to track agg function which needs to be implemented decimal type.
You have added some agg functions in https://github.com/apache/arrow-datafusion/pull/1525, I have tracked them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on issue #1545: decimal support for agg function
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1545:
URL: https://github.com/apache/arrow-datafusion/issues/1545#issuecomment-1011649647
> @liukun4515 I have added more functions and am planning to add a few in the next few days. Here are the list, please add as tasks:
>
> covar(col1, col2): calculate the covariance (sample) of col1 and col2
>
> covar_samp(col1, col2): calculate the covariance (sample) of col1 and col2
>
> covar_pop(col1, col2): calculate the covariance (population) of col1 and col2
>
> corr(col1, col2): calculate the correlation coefficient (sample) of col1 and col2
>
> corr_samp(col1, col2): calculate the correlation coefficient (sample) of col1 and col2
>
> corr_pop(col1, col2): calculate the correlation coefficient (population) of col1 and col2
>
> median(col1): calculate the median of col1
@realno please check the document of pg https://www.postgresql.org/docs/14/functions-aggregate.html
Some of agg functions don't need to support decimal type, and just need to support double precision data type(double/float64).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 edited a comment on issue #1545: decimal support for agg function
Posted by GitBox <gi...@apache.org>.
liukun4515 edited a comment on issue #1545:
URL: https://github.com/apache/arrow-datafusion/issues/1545#issuecomment-1009495696
@realno @alamb I add this issue to track agg function which needs to be implemented decimal type.
@realno You have added some agg functions in https://github.com/apache/arrow-datafusion/pull/1525, I have tracked them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org