[GitHub] [logging-log4cxx] rm5248 commented on issue #194: Compile log4cxx statically

["rm5248 (via GitHub)" <gi...@apache.org>]

rm5248 commented on issue #194:
URL: https://github.com/apache/logging-log4cxx/issues/194#issuecomment-1426894631

   I noticed this a few weeks ago, but I think the problem may be coming from about this part of the src/main/cpp/CMakeLists.txt: https://github.com/apache/logging-log4cxx/blob/afeaab6d0f0107c77dfadcbe3708f170c48d5ed9/src/main/cpp/CMakeLists.txt#L23
   
   I think that most files that need to use the private header are simply doing `#define LOG4CXX 1` before they include the private header.  I can't remember if this caused an issue or not, I can't get it to happen on Linux at least.  It seems that `LOG4CXX` should always be defined(since we are compiling the library), but `LOG4CXX_STATIC` should only be defined if building a static library.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org