[GitHub] [iceberg] nastra commented on a diff in pull request #6001: Flink: Fix NoClassDefFound with Flink runtime jar

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6001:
URL: https://github.com/apache/iceberg/pull/6001#discussion_r997738534


##########
flink/v1.15/build.gradle:
##########
@@ -146,7 +147,7 @@ project(":iceberg-flink:iceberg-flink-runtime-${flinkMajorVersion}") {
     }
 
     // for dropwizard histogram metrics implementation
-    implementation "org.apache.flink:flink-metrics-dropwizard:${flinkMajorVersion}"
+    implementation "org.apache.flink:flink-metrics-dropwizard:${flinkVersion}"

Review Comment:
   the main fix is actually moving `exclude group: 'org.apache.flink'` out of the entire `implementation` configuration so that `org.apache.flink:flink-metrics-dropwizard` can make it into the runtime jar. Once I did that, I noticed that it's trying to pick up version `1.15` (which doesn't exist) rather than `1.15.0`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org