[GitHub] [hive] jcamachor commented on a change in pull request #1492: HIVE-24154: Missing simplification opportunity with IN and EQUALS cla…

[GitBox <gi...@apache.org>]

jcamachor commented on a change in pull request #1492:
URL: https://github.com/apache/hive/pull/1492#discussion_r487545193



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java
##########
@@ -599,7 +587,7 @@ public ConstraintGroup(RexNode rexNode) {
           if (constraint == null) {
             throw new SemanticException("Unable to find constraint which was earlier added.");
           }
-          ret.add(constraint.exprNode);
+          ret.add(constraint.constNode);

Review comment:
       I was also surprised we did not catch it before! But that's OK, it was working as expected and now they are swapped back! 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org