You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Nathan Hamblen (JIRA)" <ji...@apache.org> on 2007/03/10 18:56:09 UTC
[jira] Created: (WICKET-376) form serialization doesn't recurse
into all elements
form serialization doesn't recurse into all elements
----------------------------------------------------
Key: WICKET-376
URL: https://issues.apache.org/jira/browse/WICKET-376
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3
Reporter: Nathan Hamblen
Priority: Critical
Changes made to support serialization of nested forms (http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/ajax/wicket-ajax.js?r1=515852&r2=515851&pathrev=515852) causes all DOM elements, not just form elements, to be iterated upon. However, existing code expects these elements to have a "name" attribute (and not to be disabled); lacking those, recursion stops and potential form elements below them are not considered for serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-376) form serialization doesn't recurse
into all elements
Posted by "Nathan Hamblen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nathan Hamblen updated WICKET-376:
----------------------------------
Attachment: ajax-serialize.patch
Moves the name-attribute/disabled check so that all elements are recursed into, but only those having a name and that are not disabled are passed to the element serialization method.
> form serialization doesn't recurse into all elements
> ----------------------------------------------------
>
> Key: WICKET-376
> URL: https://issues.apache.org/jira/browse/WICKET-376
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Nathan Hamblen
> Priority: Critical
> Attachments: ajax-serialize.patch
>
>
> Changes made to support serialization of nested forms (http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/ajax/wicket-ajax.js?r1=515852&r2=515851&pathrev=515852) causes all DOM elements, not just form elements, to be iterated upon. However, existing code expects these elements to have a "name" attribute (and not to be disabled); lacking those, recursion stops and potential form elements below them are not considered for serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-376) form serialization doesn't recurse
into all elements
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eelco Hillenius updated WICKET-376:
-----------------------------------
Fix Version/s: 1.3
> form serialization doesn't recurse into all elements
> ----------------------------------------------------
>
> Key: WICKET-376
> URL: https://issues.apache.org/jira/browse/WICKET-376
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Nathan Hamblen
> Priority: Critical
> Fix For: 1.3
>
> Attachments: ajax-serialize.patch
>
>
> Changes made to support serialization of nested forms (http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/ajax/wicket-ajax.js?r1=515852&r2=515851&pathrev=515852) causes all DOM elements, not just form elements, to be iterated upon. However, existing code expects these elements to have a "name" attribute (and not to be disabled); lacking those, recursion stops and potential form elements below them are not considered for serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-376) form serialization doesn't recurse
into all elements
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp resolved WICKET-376.
--------------------------------
Resolution: Fixed
> form serialization doesn't recurse into all elements
> ----------------------------------------------------
>
> Key: WICKET-376
> URL: https://issues.apache.org/jira/browse/WICKET-376
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Nathan Hamblen
> Priority: Critical
> Fix For: 1.3
>
> Attachments: ajax-serialize.patch
>
>
> Changes made to support serialization of nested forms (http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/ajax/wicket-ajax.js?r1=515852&r2=515851&pathrev=515852) causes all DOM elements, not just form elements, to be iterated upon. However, existing code expects these elements to have a "name" attribute (and not to be disabled); lacking those, recursion stops and potential form elements below them are not considered for serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-376) form serialization doesn't recurse into
all elements
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp closed WICKET-376.
------------------------------
> form serialization doesn't recurse into all elements
> ----------------------------------------------------
>
> Key: WICKET-376
> URL: https://issues.apache.org/jira/browse/WICKET-376
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Nathan Hamblen
> Priority: Critical
> Fix For: 1.3
>
> Attachments: ajax-serialize.patch
>
>
> Changes made to support serialization of nested forms (http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/ajax/wicket-ajax.js?r1=515852&r2=515851&pathrev=515852) causes all DOM elements, not just form elements, to be iterated upon. However, existing code expects these elements to have a "name" attribute (and not to be disabled); lacking those, recursion stops and potential form elements below them are not considered for serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-376) form serialization doesn't recurse
into all elements
Posted by "Nathan Hamblen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480912 ]
Nathan Hamblen commented on WICKET-376:
---------------------------------------
This can be closed. A patch from #WICKET-387 (duplicate) has been checked in.
> form serialization doesn't recurse into all elements
> ----------------------------------------------------
>
> Key: WICKET-376
> URL: https://issues.apache.org/jira/browse/WICKET-376
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3
> Reporter: Nathan Hamblen
> Priority: Critical
> Fix For: 1.3
>
> Attachments: ajax-serialize.patch
>
>
> Changes made to support serialization of nested forms (http://svn.apache.org/viewvc/incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/ajax/wicket-ajax.js?r1=515852&r2=515851&pathrev=515852) causes all DOM elements, not just form elements, to be iterated upon. However, existing code expects these elements to have a "name" attribute (and not to be disabled); lacking those, recursion stops and potential form elements below them are not considered for serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.