[GitHub] [incubator-devlake] mindlesscloud commented on a diff in pull request #5127: Support NEW_PASSWORD_REQUIRED challenge

["mindlesscloud (via GitHub)" <gi...@apache.org>]

mindlesscloud commented on code in PR #5127:
URL: https://github.com/apache/incubator-devlake/pull/5127#discussion_r1190933259


##########
backend/server/api/login/login.go:
##########
@@ -18,56 +18,64 @@ limitations under the License.
 package login
 
 import (
+	"net/http"
+
 	"github.com/apache/incubator-devlake/core/errors"
 	"github.com/apache/incubator-devlake/server/api/shared"
 	"github.com/apache/incubator-devlake/server/services/auth"
-	"net/http"
 
 	"github.com/gin-gonic/gin"
 )
 
-type LoginRequest struct {
-	Username string `json:"username"`
-	Password string `json:"password"`
-}
-
-type LoginResponse struct {
-	AuthenticationResult AuthenticationResult `json:"AuthenticationResult"`
-	ChallengeName        interface{}          `json:"ChallengeName"`
-	ChallengeParameters  ChallengeParameters  `json:"ChallengeParameters"`
-	Session              interface{}          `json:"Session"`
-}
-type AuthenticationResult struct {
-	AccessToken       string      `json:"AccessToken"`
-	ExpiresIn         int         `json:"ExpiresIn"`
-	IDToken           string      `json:"IdToken"`
-	NewDeviceMetadata interface{} `json:"NewDeviceMetadata"`
-	RefreshToken      string      `json:"RefreshToken"`
-	TokenType         string      `json:"TokenType"`
-}
-type ChallengeParameters struct {
-}
-
 // @Summary post login
 // @Description post login
 // @Tags framework/login
 // @Accept application/json
-// @Param blueprint body LoginRequest true "json"
+// @Param blueprint body aut.LoginRequest true "json"

Review Comment:
   Shall we reconsider using another param name other than `blueprint`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org