You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/01 14:24:00 UTC
[GitHub] [flink] dmvk commented on pull request #18905: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
dmvk commented on pull request #18905:
URL: https://github.com/apache/flink/pull/18905#issuecomment-1055498107
I did a quick sanity check for all connector artifacts:
```bash
find flink-connectors -type f -name '*.jar' | grep -v original | grep -v '\-test' | for i in `cat -`; do echo "==== $i ===="; jar tf $i | grep 'org/apache/flink/connector/base/source/reader/RecordEmitter'; done;
==== flink-connectors/flink-hcatalog/target/flink-hcatalog_2.12-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-elasticsearch7/target/flink-connector-elasticsearch7-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/elasticsearch7/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-sql-connector-hive-1.2.2/target/flink-sql-connector-hive-1.2.2_2.12-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-elasticsearch6/target/flink-connector-elasticsearch6-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/elasticsearch6/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-sql-connector-pulsar/target/flink-sql-connector-pulsar-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/pulsar/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-base/target/flink-connector-base-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-sql-connector-elasticsearch6/target/flink-sql-connector-elasticsearch6-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/elasticsearch6/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-sql-connector-kafka/target/flink-sql-connector-kafka-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kafka/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/kafka/sql/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-sql-connector-elasticsearch7/target/flink-sql-connector-elasticsearch7-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/elasticsearch7/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-sql-connector-kinesis/target/flink-sql-connector-kinesis-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-gcp-pubsub/target/flink-connector-gcp-pubsub-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-sql-connector-hive-2.3.6/target/flink-sql-connector-hive-2.3.6_2.12-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-jdbc/target/flink-connector-jdbc-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-hbase-base/target/flink-connector-hbase-base-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-sql-connector-hive-3.1.2/target/flink-sql-connector-hive-3.1.2_2.12-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-cassandra/target/flink-connector-cassandra_2.12-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-hive/target/flink-connector-hive_2.12-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-aws-kinesis-firehose/target/flink-connector-aws-kinesis-firehose-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/firehose/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-elasticsearch-base/target/flink-connector-elasticsearch-base-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-aws-base/target/flink-connector-aws-base-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-sql-connector-hive-2.2.0/target/flink-sql-connector-hive-2.2.0_2.12-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-kinesis/target/flink-connector-kinesis-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-file-sink-common/target/flink-file-sink-common-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-sql-connector-hbase-1.4/target/flink-sql-connector-hbase-1.4-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-kafka/target/flink-connector-kafka-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kafka/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-twitter/target/flink-connector-twitter-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-hadoop-compatibility/target/flink-hadoop-compatibility_2.12-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-files/target/flink-connector-files-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/files/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-aws-kinesis-data-streams/target/flink-connector-aws-kinesis-data-streams-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-elasticsearch5/target/flink-connector-elasticsearch5-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-hbase-1.4/target/flink-connector-hbase-1.4-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-sql-connector-rabbitmq/target/flink-sql-connector-rabbitmq-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-sql-connector-aws-kinesis-firehose/target/flink-sql-connector-aws-kinesis-firehose-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/firehose/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-sql-connector-aws-kinesis-data-streams/target/flink-sql-connector-aws-kinesis-data-streams-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-pulsar/target/flink-connector-pulsar-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/pulsar/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
==== flink-connectors/flink-connector-rabbitmq/target/flink-connector-rabbitmq-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-sql-connector-hbase-2.2/target/flink-sql-connector-hbase-2.2-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-nifi/target/flink-connector-nifi-1.15-SNAPSHOT.jar ====
==== flink-connectors/flink-connector-hbase-2.2/target/flink-connector-hbase-2.2-1.15-SNAPSHOT.jar ====
```
There seems to be some weird ones, eg.:
```bash
==== flink-connectors/flink-sql-connector-kinesis/target/flink-sql-connector-kinesis-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/kinesis/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/base/source/reader/RecordEmitter.class
```
```
==== flink-connectors/flink-sql-connector-elasticsearch7/target/flink-sql-connector-elasticsearch7-1.15-SNAPSHOT.jar ====
org/apache/flink/connector/elasticsearch7/shaded/org/apache/flink/connector/base/source/reader/RecordEmitter.class
org/apache/flink/connector/base/source/reader/RecordEmitter.class
```
If I understand the change correctly, we should always have at most one `connector-base` per "published" connector artifact, is that correct? Also should it be always properly shaded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org