You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Nico Kruber (Jira)" <ji...@apache.org> on 2020/04/08 16:38:00 UTC

[jira] [Updated] (FLINK-17056) JMH main() methods call unrelated benchmarks

     [ https://issues.apache.org/jira/browse/FLINK-17056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nico Kruber updated FLINK-17056:
--------------------------------
    Description: Each benchmark class is accompanied by an according {{public static main (String[] args)}} method which should run all benchmarks in that class. However, it just uses the class' simple name in a regexp like {{".*<name>.*"}} and may thus also match further classes that were not intended to run. An example for this is the {{StreamNetworkThroughputBenchmarkExecutor}} which also runs benchmarks from {{DataSkewStreamNetworkThroughputBenchmarkExecutor}}. Using the canonical name instead fixes that behaviour.  (was: Each benchmark class is accompanied by an according {{public static main (String[] args)}} method which should run all benchmarks in that class. However, it just uses the class' simple name in a regexp like ".*<name>.*" and may thus also match further classes that were not intended to run. An example for this is the {{StreamNetworkThroughputBenchmarkExecutor}} which also runs benchmarks from {{DataSkewStreamNetworkThroughputBenchmarkExecutor}}. Using the canonical name instead fixes that behaviour.)

> JMH main() methods call unrelated benchmarks
> --------------------------------------------
>
>                 Key: FLINK-17056
>                 URL: https://issues.apache.org/jira/browse/FLINK-17056
>             Project: Flink
>          Issue Type: Bug
>          Components: Benchmarks
>    Affects Versions: 1.10.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>             Fix For: 1.11.0
>
>
> Each benchmark class is accompanied by an according {{public static main (String[] args)}} method which should run all benchmarks in that class. However, it just uses the class' simple name in a regexp like {{".*<name>.*"}} and may thus also match further classes that were not intended to run. An example for this is the {{StreamNetworkThroughputBenchmarkExecutor}} which also runs benchmarks from {{DataSkewStreamNetworkThroughputBenchmarkExecutor}}. Using the canonical name instead fixes that behaviour.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)