You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by bu...@apache.org on 2009/10/05 21:13:20 UTC

DO NOT REPLY [Bug 47940] New: Module controller incorrectly create the replacement Sub Tree

https://issues.apache.org/bugzilla/show_bug.cgi?id=47940

           Summary: Module controller incorrectly create the replacement
                    Sub Tree
           Product: JMeter
           Version: 2.3.4
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: P2
         Component: Main
        AssignedTo: jmeter-dev@jakarta.apache.org
        ReportedBy: benoit.wiart@gmail.com


The module controller incorrectly re-create the linked controller during the
JMeter#convertSubTree step leading to erroneous scenario.

For example if we have a scenario like
TG1
    Transaction Controller
        Sampler 1
        Sampler 2
        Sampler 3

TG 2
    Module Controller (TG 1 > Transaction Controller)

Note that the Transaction Controller could be repladec by any controller
(IfController, etc...)


After the JMeter#convertSubTree step, the resulting tree for TG2 will be :
TG 2 {
    Module Controller {
        Transaction Controller {}
        Sampler 1{}
        Sampler 2{}
        Sampler 3{}
    }
}
Here the samplers and the transaction controller are sibling nodes

The correct tree should be :
TG 2 {
    Module Controller {
        Transaction Controller {
            Sampler 1{}
            Sampler 2{}
            Sampler 3{}
        }
    }
}
Where the samplers are child of the Transaction controller

Patch will follow

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 47940] [Patch] Module controller incorrectly create the replacement Sub Tree

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47940

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Sebb <se...@apache.org> 2009-11-14 15:25:07 UTC ---
Thanks:

URL: http://svn.apache.org/viewvc?rev=836291&view=rev
Log:
Bug 47940 - Module controller incorrectly creates the replacement Sub Tree

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 47940] Module controller incorrectly create the replacement Sub Tree

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47940

--- Comment #1 from benoit.wiart@gmail.com 2009-10-05 12:25:18 PDT ---
Created an attachment (id=24345)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24345)
Patch

The patch provided pass the correct subtree to the
ModuleController#createSubTree

Benoit Wiart
Ubik Ingénierie
http://www.ubik-ingenierie.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org


DO NOT REPLY [Bug 47940] [Patch] Module controller incorrectly create the replacement Sub Tree

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47940

benoit.wiart@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Module controller           |[Patch] Module controller
                   |incorrectly create the      |incorrectly create the
                   |replacement Sub Tree        |replacement Sub Tree

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org