[GitHub] [hbase] ndimiduk commented on a change in pull request #1726: HBASE-24296 install yetus as a part of building the rm docker image.

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #1726:
URL: https://github.com/apache/hbase/pull/1726#discussion_r428338954



##########
File path: dev-support/create-release/do-release.sh
##########
@@ -83,6 +83,14 @@ function should_build {
 }
 
 if should_build "tag" && [ "$SKIP_TAG" = 0 ]; then
+  if [ -z "${YETUS_HOME}" ] && [ "${RUNNING_IN_DOCKER}" != "1" ]; then
+    declare local_yetus="/opt/apache-yetus/0.11.1/"

Review comment:
       nit: you can use the symlink provided at `/usr/local/opt/yetus` to get whatever yetus version the user already has installed.

##########
File path: dev-support/create-release/do-release.sh
##########
@@ -83,6 +83,14 @@ function should_build {
 }
 
 if should_build "tag" && [ "$SKIP_TAG" = 0 ]; then
+  if [ -z "${YETUS_HOME}" ] && [ "${RUNNING_IN_DOCKER}" != "1" ]; then
+    declare local_yetus="/opt/apache-yetus/0.11.1/"

Review comment:
       Oh, you're intentionally pinning the Yetus version. Too bad you can't use `YETUS_VERSION` here...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org