You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Mck SembWever (JIRA)" <ji...@apache.org> on 2011/01/01 21:46:06 UTC

[jira] Created: (CASSANDRA-1925) "nodetool ring" to be graceful when getting ring ownerships fails

"nodetool ring" to be graceful when getting ring ownerships fails
-----------------------------------------------------------------

                 Key: CASSANDRA-1925
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1925
             Project: Cassandra
          Issue Type: Improvement
          Components: Tools
    Affects Versions: 0.7.0 rc 3
            Reporter: Mck SembWever
            Assignee: Mck SembWever
            Priority: Minor


When using a IPartitioner that doesn't support describeOwnership((List<Token>), for example see ByteOrderedPartitioner, "nodetool ring" completely fails.

"nodetool ring" can instead report this failure via stderr and still print the rest of the output it can out.

This patch provides the following (stdout) output when using a ByteOrderedParitioner

$ ./nodetool ring -h localhost 
Address         Status State   Load            Owns    Token                                       
                                                       Token(bytes[fca66e9d8e6b1ca93340302470d6ed8c])
152.90.242.93   Up     Normal  5.68 GB         ?       Token(bytes[4985c50192edae33cc5b80fa66bae81f])
152.90.242.91   Up     Normal  5.95 GB         ?       Token(bytes[a8a20dff0e2b11e087a718a90540c600])
152.90.242.92   Up     Normal  8.09 GB         ?       Token(bytes[fca66e9d8e6b1ca93340302470d6ed8c])

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1925) "nodetool ring" to be graceful when getting ring ownerships fails

Posted by "Mck SembWever (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mck SembWever updated CASSANDRA-1925:
-------------------------------------

    Attachment: CASSANDRA-1925.patch

Of course the proper solution _is_ to actually implement ByteOrderedPartitioner.describeOwnership(..)

but NodeProbe to fail gracefully is till an principled thing to do...

> "nodetool ring" to be graceful when getting ring ownerships fails
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-1925
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1925
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 0.7.0 rc 3
>            Reporter: Mck SembWever
>            Assignee: Mck SembWever
>            Priority: Minor
>         Attachments: CASSANDRA-1925.patch
>
>
> When using a IPartitioner that doesn't support describeOwnership((List<Token>), for example see ByteOrderedPartitioner, "nodetool ring" completely fails.
> "nodetool ring" can instead report this failure via stderr and still print the rest of the output it can out.
> This patch provides the following (stdout) output when using a ByteOrderedParitioner
> $ ./nodetool ring -h localhost 
> Address         Status State   Load            Owns    Token                                       
>                                                        Token(bytes[fca66e9d8e6b1ca93340302470d6ed8c])
> 152.90.242.93   Up     Normal  5.68 GB         ?       Token(bytes[4985c50192edae33cc5b80fa66bae81f])
> 152.90.242.91   Up     Normal  5.95 GB         ?       Token(bytes[a8a20dff0e2b11e087a718a90540c600])
> 152.90.242.92   Up     Normal  8.09 GB         ?       Token(bytes[fca66e9d8e6b1ca93340302470d6ed8c])

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (CASSANDRA-1925) "nodetool ring" to be graceful when getting ring ownerships fails

Posted by "Mck SembWever (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976447#action_12976447 ] 

Mck SembWever edited comment on CASSANDRA-1925 at 1/2/11 2:46 AM:
------------------------------------------------------------------

Of course the proper solution _is_ to actually implement ByteOrderedPartitioner.describeOwnership(..)

but NodeProbe to fail gracefully is still an principled thing to do...

      was (Author: michaelsembwever):
    Of course the proper solution _is_ to actually implement ByteOrderedPartitioner.describeOwnership(..)

but NodeProbe to fail gracefully is till an principled thing to do...
  
> "nodetool ring" to be graceful when getting ring ownerships fails
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-1925
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1925
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 0.7.0 rc 3
>            Reporter: Mck SembWever
>            Assignee: Mck SembWever
>            Priority: Minor
>         Attachments: CASSANDRA-1925.patch
>
>
> When using a IPartitioner that doesn't support describeOwnership((List<Token>), for example see ByteOrderedPartitioner, "nodetool ring" completely fails.
> "nodetool ring" can instead report this failure via stderr and still print the rest of the output it can out.
> This patch provides the following (stdout) output when using a ByteOrderedParitioner
> $ ./nodetool ring -h localhost 
> Address         Status State   Load            Owns    Token                                       
>                                                        Token(bytes[fca66e9d8e6b1ca93340302470d6ed8c])
> 152.90.242.93   Up     Normal  5.68 GB         ?       Token(bytes[4985c50192edae33cc5b80fa66bae81f])
> 152.90.242.91   Up     Normal  5.95 GB         ?       Token(bytes[a8a20dff0e2b11e087a718a90540c600])
> 152.90.242.92   Up     Normal  8.09 GB         ?       Token(bytes[fca66e9d8e6b1ca93340302470d6ed8c])

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.