You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2014/10/16 23:31:10 UTC
Review Request 26828: Remove info logging when users request json
output
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-860
https://issues.apache.org/jira/browse/AURORA-860
Repository: aurora
Description
-------
Remove info logging when users request json output
Diffs
-----
src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
Diff: https://reviews.apache.org/r/26828/diff/
Testing
-------
[tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:status
Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, status)])
==================================================================================================================================================== test session starts =====================================================================================================================================================
platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 12 items
src/test/python/apache/aurora/client/cli/test_status.py ............
================================================================================================================================================= 12 passed in 1.34 seconds ==================================================================================================================================================
src.test.python.apache.aurora.client.cli.status ..... SUCCESS
Thanks,
Joe Smith
Re: Review Request 26828: Remove info logging when users request json
output
Posted by Joe Smith <ya...@gmail.com>.
> On Oct. 16, 2014, 2:38 p.m., Alex Levenson wrote:
> > src/main/python/apache/aurora/client/api/__init__.py, line 107
> > <https://reviews.apache.org/r/26828/diff/1/?file=723414#file723414line107>
> >
> > might want to be consistent with "squelch" and "clean_output"? Choose one, or even call it "suppress_logging" or something like that?
Great call, thanks.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57004
-----------------------------------------------------------
On Oct. 16, 2014, 2:31 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 2:31 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove info logging when users request json output
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
> src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
> src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
> src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
> src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
>
> Diff: https://reviews.apache.org/r/26828/diff/
>
>
> Testing
> -------
>
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:status
> Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, status)])
> ==================================================================================================================================================== test session starts =====================================================================================================================================================
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 12 items
>
> src/test/python/apache/aurora/client/cli/test_status.py ............
>
> ================================================================================================================================================= 12 passed in 1.34 seconds ==================================================================================================================================================
> src.test.python.apache.aurora.client.cli.status ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26828: Remove info logging when users request json
output
Posted by Alex Levenson <al...@isnotinvain.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57004
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/api/__init__.py
<https://reviews.apache.org/r/26828/#comment97443>
might want to be consistent with "squelch" and "clean_output"? Choose one, or even call it "suppress_logging" or something like that?
- Alex Levenson
On Oct. 16, 2014, 9:31 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 9:31 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove info logging when users request json output
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
> src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
> src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
> src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
> src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
>
> Diff: https://reviews.apache.org/r/26828/diff/
>
>
> Testing
> -------
>
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:status
> Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, status)])
> ==================================================================================================================================================== test session starts =====================================================================================================================================================
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 12 items
>
> src/test/python/apache/aurora/client/cli/test_status.py ............
>
> ================================================================================================================================================= 12 passed in 1.34 seconds ==================================================================================================================================================
> src.test.python.apache.aurora.client.cli.status ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26828: Remove info logging when users request json
output
Posted by Joe Smith <ya...@gmail.com>.
> On Oct. 16, 2014, 4:22 p.m., Alex Levenson wrote:
> > Sorry all, I may have reported this one too early -- I think the log.info statements are going to stderr, in which case anyone parsing the json output that's sent to stdout should have no problems.
No worries- thanks for kicking the tires and helping make aurora better! :)
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57044
-----------------------------------------------------------
On Oct. 16, 2014, 2:40 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 2:40 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove info logging when users request json output
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
> src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
> src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
> src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
> src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
>
> Diff: https://reviews.apache.org/r/26828/diff/
>
>
> Testing
> -------
>
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:job
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26828: Remove info logging when users request json
output
Posted by Alex Levenson <al...@isnotinvain.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57044
-----------------------------------------------------------
Sorry all, I may have reported this one too early -- I think the log.info statements are going to stderr, in which case anyone parsing the json output that's sent to stdout should have no problems.
- Alex Levenson
On Oct. 16, 2014, 9:40 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 9:40 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove info logging when users request json output
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
> src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
> src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
> src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
> src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
>
> Diff: https://reviews.apache.org/r/26828/diff/
>
>
> Testing
> -------
>
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:job
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26828: Remove info logging when users request json
output
Posted by Joe Smith <ya...@gmail.com>.
> On Oct. 16, 2014, 2:43 p.m., Zameer Manji wrote:
> > I feel we will need to revisit the json output in the future to ensure that we don't have to do this process for every subcommand.
Agreed.
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57008
-----------------------------------------------------------
On Oct. 16, 2014, 2:40 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 2:40 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove info logging when users request json output
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
> src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
> src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
> src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
> src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
>
> Diff: https://reviews.apache.org/r/26828/diff/
>
>
> Testing
> -------
>
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:job
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26828: Remove info logging when users request json
output
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57008
-----------------------------------------------------------
Ship it!
I feel we will need to revisit the json output in the future to ensure that we don't have to do this process for every subcommand.
- Zameer Manji
On Oct. 16, 2014, 2:40 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 2:40 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove info logging when users request json output
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
> src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
> src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
> src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
> src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
>
> Diff: https://reviews.apache.org/r/26828/diff/
>
>
> Testing
> -------
>
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:job
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26828: Remove info logging when users request json
output
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/#review57011
-----------------------------------------------------------
Weird - I'd think we want logging when the user has requested JSON output - as presumably a wrapper tool can 2>/dev/null easier than a user one
- Kevin Sweeney
On Oct. 16, 2014, 2:40 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26828/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 2:40 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-860
> https://issues.apache.org/jira/browse/AURORA-860
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove info logging when users request json output
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
> src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
> src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
> src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
> src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
>
> Diff: https://reviews.apache.org/r/26828/diff/
>
>
> Testing
> -------
>
> [tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:job
>
>
> Thanks,
>
> Joe Smith
>
>
Re: Review Request 26828: Remove info logging when users request json
output
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 2:40 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
alex's catch
Bugs: AURORA-860
https://issues.apache.org/jira/browse/AURORA-860
Repository: aurora
Description
-------
Remove info logging when users request json output
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/__init__.py d12132f8ee64a390c9b5b4c9ab26b5e4b2b1bb59
src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e
src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0
src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c
src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8
Diff: https://reviews.apache.org/r/26828/diff/
Testing (updated)
-------
[tw-172-25-132-201 aurora (jsmith/status_json)]$ ./pants ./src/test/python/apache/aurora/client/cli:job
Thanks,
Joe Smith