You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/02/25 19:09:42 UTC

[kudu-CR](branch-1.18.x) [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22543


Change subject: [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue
......................................................................

[rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

With protobuf 3.21.9, the TimedOutOnResponseMetricServiceQueue scenario
of the TestRpc suite started reporting an error like below, that
sometimes leads to failures as reported by [1].  This patch addresses
the issue.

  [libprotobuf ERROR thirdparty/src/protobuf-3.21.9/src/google/protobuf/message_lite.cc:133] Can't parse message of type "kudu.rpc_test.SleepRequestPB" because it is missing required fields: sleep_micros
  W20250221 18:47:46.831769 207179 service_if.cc:72] invalid parameter for call kudu.rpc_test.CalculatorService.Sleep: missing fields: sleep_micros

This is a follow-up to 0d837c5aac482fbe46170e26ac45e5ad951eecec.

[1] http://dist-test.cloudera.org:8080/diagnose?key=cc8af164-eda5-11ef-a520-42010af00016

Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Reviewed-on: http://gerrit.cloudera.org:8080/22520
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit eb1c5a110944a0f6d8b34446a8c4e21c2e316b34)
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/22543/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Gerrit-Change-Number: 22543
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22543 )

Change subject: [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue
......................................................................

[rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

With protobuf 3.21.9, the TimedOutOnResponseMetricServiceQueue scenario
of the TestRpc suite started reporting an error like below, that
sometimes leads to failures as reported by [1].  This patch addresses
the issue.

  [libprotobuf ERROR thirdparty/src/protobuf-3.21.9/src/google/protobuf/message_lite.cc:133] Can't parse message of type "kudu.rpc_test.SleepRequestPB" because it is missing required fields: sleep_micros
  W20250221 18:47:46.831769 207179 service_if.cc:72] invalid parameter for call kudu.rpc_test.CalculatorService.Sleep: missing fields: sleep_micros

This is a follow-up to 0d837c5aac482fbe46170e26ac45e5ad951eecec.

[1] http://dist-test.cloudera.org:8080/diagnose?key=cc8af164-eda5-11ef-a520-42010af00016

Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Reviewed-on: http://gerrit.cloudera.org:8080/22520
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
(cherry picked from commit eb1c5a110944a0f6d8b34446a8c4e21c2e316b34)
Reviewed-on: http://gerrit.cloudera.org:8080/22543
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Gerrit-Change-Number: 22543
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR](branch-1.18.x) [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Gerrit-Change-Number: 22543
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR](branch-1.18.x) [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22543 )

Change subject: [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue
......................................................................


Patch Set 1: Verified+1

unrelated test failure (DEBUG): fs_manager-test


-- 
To view, visit http://gerrit.cloudera.org:8080/22543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Gerrit-Change-Number: 22543
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 21:56:04 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22543 )

Change subject: [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1116/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Gerrit-Change-Number: 22543
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 20:43:31 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22543 )

Change subject: [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Gerrit-Change-Number: 22543
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 21:45:52 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22543 )

Change subject: [rpc-test] fix missing field in TimedOutOnResponseMetricServiceQueue
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1116/


-- 
To view, visit http://gerrit.cloudera.org:8080/22543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I097916c6ffbb7b7368d67233b47427db2cefd185
Gerrit-Change-Number: 22543
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Feb 2025 19:09:49 +0000
Gerrit-HasComments: No