[GitHub] [druid] nishantmonu51 commented on a change in pull request #11276: Allow query through router when load moving average extension

[GitBox <gi...@apache.org>]

nishantmonu51 commented on a change in pull request #11276:
URL: https://github.com/apache/druid/pull/11276#discussion_r636521946



##########
File path: services/src/main/java/org/apache/druid/cli/FakeQuerySegmentWalker.java
##########
@@ -0,0 +1,22 @@
+package org.apache.druid.cli;
+
+import org.apache.druid.query.Query;
+import org.apache.druid.query.QueryRunner;
+import org.apache.druid.query.QuerySegmentWalker;
+import org.apache.druid.query.SegmentDescriptor;
+import org.joda.time.Interval;
+
+public class FakeQuerySegmentWalker implements QuerySegmentWalker

Review comment:
       nit: rename to NoopQuerySegmentWalker to be consistent with other druid naming conventions. 

##########
File path: services/src/main/java/org/apache/druid/cli/CliRouter.java
##########
@@ -91,6 +92,8 @@ public CliRouter()
           JsonConfigProvider.bind(binder, "druid.router.avatica.balancer", AvaticaConnectionBalancer.class);
           JsonConfigProvider.bind(binder, "druid.router.managementProxy", ManagementProxyConfig.class);
 
+          binder.bind(QuerySegmentWalker.class).to(FakeQuerySegmentWalker.class).in(LazySingleton.class);

Review comment:
       I would also add a comment mentioning that Router is just used to route the query to appropriate broker, so it is bound to a Noop walker. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org