You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by eminency <gi...@git.apache.org> on 2014/12/18 17:27:53 UTC
[GitHub] tajo pull request: Tajo-1258: Close() derived FileAppender should ...
GitHub user eminency opened a pull request:
https://github.com/apache/tajo/pull/309
Tajo-1258: Close() derived FileAppender should consider inited state
Close() for FileAppender is added and derived classes use it to check initialization state.
This modification is also including resolution for TAJO-1227.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eminency/tajo TAJO-1258
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #309
----
commit 205331847c2a44381299ab1c9fed4c9c7370472e
Author: Jongyoung Park <em...@gmail.com>
Date: 2014-12-18T16:19:29Z
Close() for FileAppender is added and derived classes are modified
commit 7fb632de1860065f287b87498abe9a85eb95848c
Author: Jihoon Son <ji...@apache.org>
Date: 2014-12-18T07:50:09Z
TAJO-1232: Implicit groupby queries with LIMIT lead to wrong results. (jihoon)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Tajo-1258: Close() for classes derived from Fil...
Posted by eminency <gi...@git.apache.org>.
Github user eminency closed the pull request at:
https://github.com/apache/tajo/pull/309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Tajo-1258: Close() for classes derived from Fil...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/309#issuecomment-68260042
@eminency Thank you for your contribution
File or stream or buffer should close, if these open.
In my opinion, we just need to add safety closing. such as IOUtils.cleanup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: Tajo-1258: Close() for classes derived from Fil...
Posted by eminency <gi...@git.apache.org>.
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/309#issuecomment-68324730
Thank you for suggestion, @jinossy .
It looks like smarter way.
I will study and work on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---