You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mridulm <gi...@git.apache.org> on 2014/05/03 22:34:08 UTC

[GitHub] spark pull request: Fix SPARK-1629: Spark should inline use of com...

Github user mridulm commented on the pull request:

    https://github.com/apache/spark/pull/569#issuecomment-42115677
  
    I am still catching up on PR's and bugs.
    Why was this changed ?
    Hacky solutions based on string parsing of properties lead to fragility in case of changes in future.
    Since we are already depending on apache commons, makes sense to delegate to that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---