You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hwani3142 (via GitHub)" <gi...@apache.org> on 2024/05/04 16:18:59 UTC
[PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
hwani3142 opened a new pull request, #11149:
URL: https://github.com/apache/hudi/pull/11149
### Change Logs
fix copy logic on MultiTableStreamer
### Impact
HoodieMultiTableStreamer
### Risk level (write none, low medium or high below)
low
### Documentation Update
none
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365006421
@hwani3142 I created a docs update ticket for you: HUDI-8225.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "fijemax (via GitHub)" <gi...@apache.org>.
fijemax commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2289147386
Any news on this issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1728734925
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieMultiTableStreamer.java:
##########
@@ -430,6 +432,99 @@ public static class Config implements Serializable {
@Parameter(names = {"--help", "-h"}, help = true)
public Boolean help = false;
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
Do we need the equals and toString implementation here?
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/streamer/TestStreamSyncUnitTests.java:
##########
@@ -160,6 +165,45 @@ void testGetCheckpointToResume(HoodieStreamer.Config cfg, HoodieCommitMetadata c
assertEquals(expectedResumeCheckpoint,resumeCheckpoint);
}
+ @ParameterizedTest
+ @MethodSource("getMultiTableStreamerCases")
+ void testCloneConfigsFromMultiTableStreamer(HoodieMultiTableStreamer.Config cfg) throws IOException {
+ Configuration configuration = new Configuration();
+ JavaSparkContext jssc = mock(JavaSparkContext.class);
+
+ when(jssc.hadoopConfiguration()).thenReturn(configuration);
+
+ HoodieMultiTableStreamer multiTableStreamer = new HoodieMultiTableStreamer(cfg, jssc);
+ List<TableExecutionContext> tableExecutionContextList = multiTableStreamer.getTableExecutionContexts();
+ tableExecutionContextList.forEach(it -> {
+ // make sure that if set global properties then each child streamer can get also
+ assertTrue(it.getConfig().configs.containsAll(cfg.configs));
Review Comment:
Can we also add a check for `cfg.configs` to be non empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1730740068
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieMultiTableStreamer.java:
##########
@@ -430,6 +432,99 @@ public static class Config implements Serializable {
@Parameter(names = {"--help", "-h"}, help = true)
public Boolean help = false;
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
Should we consider API like
https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/builder/EqualsBuilder.html#reflectionEquals(java.lang.Object,%20java.lang.Object)?
The equals and hashCode are not implemented in other config classes as well. But if we need it we can retain the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365007813
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
}, {
"hash" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"triggerType" : "PUSH"
}, {
"hash" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
}, {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=656",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
}, {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654) Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=656)
* 5fbd99a37fda1d73b938bfea99824b99d7553fee UNKNOWN
* 40aada745de172ff37dd143d97cffe0d7b73764d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2346906346
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb03750d5e951785c6205f501d463614cc3315cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657",
"triggerID" : "bb03750d5e951785c6205f501d463614cc3315cf",
"triggerType" : "PUSH"
}, {
"hash" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=421",
"triggerID" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"triggerType" : "PUSH"
}, {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=424",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=424)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1730720592
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/streamer/TestStreamSyncUnitTests.java:
##########
@@ -160,6 +165,45 @@ void testGetCheckpointToResume(HoodieStreamer.Config cfg, HoodieCommitMetadata c
assertEquals(expectedResumeCheckpoint,resumeCheckpoint);
}
+ @ParameterizedTest
+ @MethodSource("getMultiTableStreamerCases")
+ void testCloneConfigsFromMultiTableStreamer(HoodieMultiTableStreamer.Config cfg) throws IOException {
+ Configuration configuration = new Configuration();
+ JavaSparkContext jssc = mock(JavaSparkContext.class);
+
+ when(jssc.hadoopConfiguration()).thenReturn(configuration);
+
+ HoodieMultiTableStreamer multiTableStreamer = new HoodieMultiTableStreamer(cfg, jssc);
+ List<TableExecutionContext> tableExecutionContextList = multiTableStreamer.getTableExecutionContexts();
+ tableExecutionContextList.forEach(it -> {
+ // make sure that if set global properties then each child streamer can get also
+ assertTrue(it.getConfig().configs.containsAll(cfg.configs));
Review Comment:
I just wanted to ensure we have a test which covers the case where the configs are non empty. I see that is already covered based on the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer to read per-stream properties file [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #11149:
URL: https://github.com/apache/hudi/pull/11149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hwani3142 (via GitHub)" <gi...@apache.org>.
hwani3142 commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1728901184
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieMultiTableStreamer.java:
##########
@@ -430,6 +432,99 @@ public static class Config implements Serializable {
@Parameter(names = {"--help", "-h"}, help = true)
public Boolean help = false;
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
I think that every config class should have equals, hashCode, toString for convenience.
If not, can rollback them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365007162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
}, {
"hash" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"triggerType" : "PUSH"
}, {
"hash" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
}, {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=656",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654) Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=656)
* 5fbd99a37fda1d73b938bfea99824b99d7553fee UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hwani3142 (via GitHub)" <gi...@apache.org>.
hwani3142 commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1757137854
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieMultiTableStreamer.java:
##########
@@ -430,6 +432,99 @@ public static class Config implements Serializable {
@Parameter(names = {"--help", "-h"}, help = true)
public Boolean help = false;
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
I refered [Config on HoodieStreamer](https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java#L222)
rollback this, because it is not main for this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2094288851
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb03750d5e951785c6205f501d463614cc3315cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bb03750d5e951785c6205f501d463614cc3315cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb03750d5e951785c6205f501d463614cc3315cf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365012522
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=658",
"triggerID" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"triggerType" : "PUSH"
}, {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=659",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 40aada745de172ff37dd143d97cffe0d7b73764d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=658) Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=659)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hwani3142 (via GitHub)" <gi...@apache.org>.
hwani3142 commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2346654551
@yihua
I missed reviews
Sorry for delaying check comments.
@lokeshj1703
Please review remains again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2364997826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2364997476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2346641254
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb03750d5e951785c6205f501d463614cc3315cf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657",
"triggerID" : "bb03750d5e951785c6205f501d463614cc3315cf",
"triggerType" : "PUSH"
}, {
"hash" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb03750d5e951785c6205f501d463614cc3315cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657)
* f7ea12d8a60a290cd424476e975075e82289a4b6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2094305741
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb03750d5e951785c6205f501d463614cc3315cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657",
"triggerID" : "bb03750d5e951785c6205f501d463614cc3315cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb03750d5e951785c6205f501d463614cc3315cf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365012877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=658",
"triggerID" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"triggerType" : "PUSH"
}, {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=659",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
}, {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=658",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 40aada745de172ff37dd143d97cffe0d7b73764d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=659) Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=658)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1769476979
##########
hudi-utilities/src/test/resources/streamer-config/kafka-source-multi.properties:
##########
@@ -0,0 +1,33 @@
+###
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###
+include=base.properties
+# Key fields, for kafka example
+#hoodie.datasource.write.recordkey.field=_row_key
+#hoodie.datasource.write.partitionpath.field=driver
+# schema provider configs
+hoodie.streamer.schemaprovider.registry.url=http://localhost:8081/subjects/random-value/versions/latest
+# Kafka Source
+#hoodie.streamer.source.kafka.topic=impressions
Review Comment:
```suggestion
```
##########
hudi-utilities/src/test/resources/streamer-config/multi-source-1.properties:
##########
@@ -0,0 +1,26 @@
+###
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###
+include=base.properties
+# Key generator props
+hoodie.datasource.write.recordkey.field=_row_key
+hoodie.datasource.write.partitionpath.field=driver
+hoodie.streamer.source.kafka.topic=TOPIC_1
+# Schema provider props (change to absolute path based on your installation)
Review Comment:
```suggestion
# Schema provider props
```
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/streamer/TestStreamSyncUnitTests.java:
##########
@@ -160,6 +165,45 @@ void testGetCheckpointToResume(HoodieStreamer.Config cfg, HoodieCommitMetadata c
assertEquals(expectedResumeCheckpoint,resumeCheckpoint);
}
+ @ParameterizedTest
+ @MethodSource("getMultiTableStreamerCases")
+ void testCloneConfigsFromMultiTableStreamer(HoodieMultiTableStreamer.Config cfg) throws IOException {
+ Configuration configuration = new Configuration();
+ JavaSparkContext jssc = mock(JavaSparkContext.class);
+
+ when(jssc.hadoopConfiguration()).thenReturn(configuration);
+
+ HoodieMultiTableStreamer multiTableStreamer = new HoodieMultiTableStreamer(cfg, jssc);
+ List<TableExecutionContext> tableExecutionContextList = multiTableStreamer.getTableExecutionContexts();
+ tableExecutionContextList.forEach(it -> {
+ // make sure that if set global properties then each child streamer can get also
+ assertTrue(it.getConfig().configs.containsAll(cfg.configs));
+
+ // make sure that each streamer should have propsFilePath from multiStreamer configs, not default value
Review Comment:
```suggestion
// make sure that each child streamer obtains the propsFilePath from multiStreamer configs, not the default value
```
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/streamer/TestStreamSyncUnitTests.java:
##########
@@ -160,6 +165,45 @@ void testGetCheckpointToResume(HoodieStreamer.Config cfg, HoodieCommitMetadata c
assertEquals(expectedResumeCheckpoint,resumeCheckpoint);
}
+ @ParameterizedTest
+ @MethodSource("getMultiTableStreamerCases")
+ void testCloneConfigsFromMultiTableStreamer(HoodieMultiTableStreamer.Config cfg) throws IOException {
+ Configuration configuration = new Configuration();
+ JavaSparkContext jssc = mock(JavaSparkContext.class);
+
+ when(jssc.hadoopConfiguration()).thenReturn(configuration);
+
+ HoodieMultiTableStreamer multiTableStreamer = new HoodieMultiTableStreamer(cfg, jssc);
+ List<TableExecutionContext> tableExecutionContextList = multiTableStreamer.getTableExecutionContexts();
+ tableExecutionContextList.forEach(it -> {
+ // make sure that if set global properties then each child streamer can get also
Review Comment:
```suggestion
// make sure that the global properties are also set in each child streamer
```
##########
hudi-utilities/src/test/resources/streamer-config/multi-source-2.properties:
##########
@@ -0,0 +1,26 @@
+###
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###
+include=base.properties
+# Key generator props
+hoodie.datasource.write.recordkey.field=_row_key
+hoodie.datasource.write.partitionpath.field=driver
+hoodie.streamer.source.kafka.topic=TOPIC_2
+# Schema provider props (change to absolute path based on your installation)
Review Comment:
```suggestion
# Schema provider props
```
##########
hudi-utilities/src/test/resources/streamer-config/multi-source-2.properties:
##########
@@ -0,0 +1,26 @@
+###
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###
+include=base.properties
+# Key generator props
+hoodie.datasource.write.recordkey.field=_row_key
+hoodie.datasource.write.partitionpath.field=driver
+hoodie.streamer.source.kafka.topic=TOPIC_2
+# Schema provider props (change to absolute path based on your installation)
+hoodie.streamer.schemaprovider.source.schema.file=file:///path/to/hoodie/hoodie-utilities/src/main/resources/streamer-props/source.avsc
+hoodie.streamer.schemaprovider.target.schema.file=file:///path/to/hoodie/hoodie-utilities/src/main/resources/streamer-props/target.avsc
+
Review Comment:
```suggestion
```
##########
hudi-utilities/src/test/resources/streamer-config/kafka-source-multi.properties:
##########
@@ -0,0 +1,33 @@
+###
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###
+include=base.properties
+# Key fields, for kafka example
+#hoodie.datasource.write.recordkey.field=_row_key
+#hoodie.datasource.write.partitionpath.field=driver
Review Comment:
Remove unused configs
```suggestion
```
##########
hudi-utilities/src/test/resources/streamer-config/multi-source-1.properties:
##########
@@ -0,0 +1,26 @@
+###
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###
+include=base.properties
+# Key generator props
+hoodie.datasource.write.recordkey.field=_row_key
+hoodie.datasource.write.partitionpath.field=driver
+hoodie.streamer.source.kafka.topic=TOPIC_1
+# Schema provider props (change to absolute path based on your installation)
+hoodie.streamer.schemaprovider.source.schema.file=file:///path/to/hoodie/hoodie-utilities/src/main/resources/streamer-props/source.avsc
+hoodie.streamer.schemaprovider.target.schema.file=file:///path/to/hoodie/hoodie-utilities/src/main/resources/streamer-props/target.avsc
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365006857
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
}, {
"hash" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654)
* 5fbd99a37fda1d73b938bfea99824b99d7553fee UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365012118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 40aada745de172ff37dd143d97cffe0d7b73764d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365007486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
}, {
"hash" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"triggerType" : "PUSH"
}, {
"hash" : "5fbd99a37fda1d73b938bfea99824b99d7553fee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
}, {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=656",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=654) Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=656)
* 5fbd99a37fda1d73b938bfea99824b99d7553fee UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365007029
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2346778885
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb03750d5e951785c6205f501d463614cc3315cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657",
"triggerID" : "bb03750d5e951785c6205f501d463614cc3315cf",
"triggerType" : "PUSH"
}, {
"hash" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=421",
"triggerID" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"triggerType" : "PUSH"
}, {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=424",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7ea12d8a60a290cd424476e975075e82289a4b6 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=421)
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=424)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2094335208
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb03750d5e951785c6205f501d463614cc3315cf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657",
"triggerID" : "bb03750d5e951785c6205f501d463614cc3315cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb03750d5e951785c6205f501d463614cc3315cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2346644182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb03750d5e951785c6205f501d463614cc3315cf",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657",
"triggerID" : "bb03750d5e951785c6205f501d463614cc3315cf",
"triggerType" : "PUSH"
}, {
"hash" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=421",
"triggerID" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"triggerType" : "PUSH"
}, {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bb03750d5e951785c6205f501d463614cc3315cf Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657)
* f7ea12d8a60a290cd424476e975075e82289a4b6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=421)
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2346647196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bb03750d5e951785c6205f501d463614cc3315cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=23657",
"triggerID" : "bb03750d5e951785c6205f501d463614cc3315cf",
"triggerType" : "PUSH"
}, {
"hash" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=421",
"triggerID" : "f7ea12d8a60a290cd424476e975075e82289a4b6",
"triggerType" : "PUSH"
}, {
"hash" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b6f30add8f0b220ab70b24913c2a67b15f5b3e17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7ea12d8a60a290cd424476e975075e82289a4b6 Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=421)
* b6f30add8f0b220ab70b24913c2a67b15f5b3e17 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #11149:
URL: https://github.com/apache/hudi/pull/11149#issuecomment-2365031521
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=658",
"triggerID" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"triggerType" : "PUSH"
}, {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=659",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
}, {
"hash" : "40aada745de172ff37dd143d97cffe0d7b73764d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=658",
"triggerID" : "2365007029",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 40aada745de172ff37dd143d97cffe0d7b73764d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=659) Azure: [CANCELED](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=658)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7711] Fix MultiTableStreamer can deal with path of properties files [hudi]
Posted by "hwani3142 (via GitHub)" <gi...@apache.org>.
hwani3142 commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1728904841
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/streamer/TestStreamSyncUnitTests.java:
##########
@@ -160,6 +165,45 @@ void testGetCheckpointToResume(HoodieStreamer.Config cfg, HoodieCommitMetadata c
assertEquals(expectedResumeCheckpoint,resumeCheckpoint);
}
+ @ParameterizedTest
+ @MethodSource("getMultiTableStreamerCases")
+ void testCloneConfigsFromMultiTableStreamer(HoodieMultiTableStreamer.Config cfg) throws IOException {
+ Configuration configuration = new Configuration();
+ JavaSparkContext jssc = mock(JavaSparkContext.class);
+
+ when(jssc.hadoopConfiguration()).thenReturn(configuration);
+
+ HoodieMultiTableStreamer multiTableStreamer = new HoodieMultiTableStreamer(cfg, jssc);
+ List<TableExecutionContext> tableExecutionContextList = multiTableStreamer.getTableExecutionContexts();
+ tableExecutionContextList.forEach(it -> {
+ // make sure that if set global properties then each child streamer can get also
+ assertTrue(it.getConfig().configs.containsAll(cfg.configs));
Review Comment:
@lokeshj1703
We should allow to have empty configs.
[Test case 1](https://github.com/apache/hudi/pull/11149/files#diff-d5d9e34abfadbfc00ca3aa1642dbfde1a59ecaf2976ce7a5be418e9ae0a1a17fR192) address that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org