You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/09/26 12:45:04 UTC
[GitHub] [incubator-kyuubi] iodone opened a new pull request, #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
iodone opened a new pull request, #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
Closes #3444
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
wForget commented on PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#issuecomment-1340300201
We can define a PlanOnlyStatement mode interface in Engine, and then implement it in the lineage plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r982304979
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
how about have a rule or logic inside the lineage plugin, the engine side can push down a config or something, then you determine the output
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r981981953
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
any idea about removing this from the engine？ It makes engine module hard for long-term maintenance and cross version support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r1000069902
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
Can we just make the full functionality on the plugin side? IMHO, it is not necessary to include a dependency based on my experience to create more than one plugins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you closed pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you closed pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
URL: https://github.com/apache/kyuubi/pull/3558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r981922614
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala:
##########
@@ -136,10 +142,25 @@ class PlanOnlyStatement(
case ExecutionMode =>
val executed = spark.sql(statement).queryExecution.executedPlan
iter = new IterableFetchIterator(Seq(Row(executed.toJSON)))
+ case LineageMode =>
+ val result = parseLineage(spark, plan)
+ iter = new IterableFetchIterator(Seq(Row(result)))
case UnknownMode => throw unknownModeError(mode)
case _ =>
throw KyuubiSQLException(s"The operation mode $mode" +
" doesn't support in Spark SQL engine.")
}
}
+
+ private def parseLineage(spark: SparkSession, plan: LogicalPlan): String = {
+ val analyzed = spark.sessionState.analyzer.execute(plan)
+ spark.sessionState.analyzer.checkAnalysis(analyzed)
+ val optimized = spark.sessionState.optimizer.execute(analyzed)
+ val lineageParser = new LineageParser { def sparkSession = spark }
+ val lineage = lineageParser.parse(optimized)
+
+ val mapper = new ObjectMapper().registerModule(DefaultScalaModule)
+ val r = mapper.writeValueAsString(lineage)
+ r
Review Comment:
unnecessary variable
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala:
##########
@@ -136,10 +142,25 @@ class PlanOnlyStatement(
case ExecutionMode =>
val executed = spark.sql(statement).queryExecution.executedPlan
iter = new IterableFetchIterator(Seq(Row(executed.toJSON)))
+ case LineageMode =>
+ val result = parseLineage(spark, plan)
+ iter = new IterableFetchIterator(Seq(Row(result)))
case UnknownMode => throw unknownModeError(mode)
case _ =>
throw KyuubiSQLException(s"The operation mode $mode" +
" doesn't support in Spark SQL engine.")
}
}
+
+ private def parseLineage(spark: SparkSession, plan: LogicalPlan): String = {
+ val analyzed = spark.sessionState.analyzer.execute(plan)
+ spark.sessionState.analyzer.checkAnalysis(analyzed)
Review Comment:
`optimized` has done this check ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
iodone commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r1005616821
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
@yaooqinn I have removed the dependency with your advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] ulysses-you commented on pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #3558:
URL: https://github.com/apache/kyuubi/pull/3558#issuecomment-1702499205
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
iodone commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r995375323
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/KyuubiSparkUtil.scala:
##########
@@ -93,4 +96,13 @@ object KyuubiSparkUtil extends Logging {
val runtimeVersion = SemanticVersion(runtimeSparkVer)
(runtimeVersion.majorVersion, runtimeVersion.minorVersion)
}
+
+ def parsePlan(spark: SparkSession, plan: LogicalPlan): String = {
+ import org.apache.kyuubi.plugin.lineage.helper.LineageParser
+ val lineageParser =
+ new LineageParser { def sparkSession = spark }
Review Comment:
Using reflection is similar to setting the dependency of spark-lineage-plugin to `optional` and requires that this dependency logic be put into a separate file to pass all the unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
iodone commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r982011597
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
@yaooqinn @ulysses-you @cfmcgrady
https://github.com/apache/incubator-kyuubi/pull/3537#issuecomment-1260305095 Here just discussed the dependency with the plugin. @wForget suggested extracting the common module to reuse `SQLLineageParserHelper`, can you give some other advice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r982302357
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
A spark engine plugin can depend on engine lib(not suggested, but ok) and spark libs for the compilation phase, but the engine lib can not do the opposite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r994587284
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/KyuubiSparkUtil.scala:
##########
@@ -93,4 +96,13 @@ object KyuubiSparkUtil extends Logging {
val runtimeVersion = SemanticVersion(runtimeSparkVer)
(runtimeVersion.majorVersion, runtimeVersion.minorVersion)
}
+
+ def parsePlan(spark: SparkSession, plan: LogicalPlan): String = {
+ import org.apache.kyuubi.plugin.lineage.helper.LineageParser
+ val lineageParser =
+ new LineageParser { def sparkSession = spark }
Review Comment:
can we use reflect here ? then we can remove maven dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] iodone commented on pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by "iodone (via GitHub)" <gi...@apache.org>.
iodone commented on PR #3558:
URL: https://github.com/apache/kyuubi/pull/3558#issuecomment-1702300938
@yaooqinn @wForget This feature has been overlooked. A new version has recently been released. The engine has removed the strong dependency on the plugin by reflecting on the provider class of the plugin. Can you help me review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r982013788
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
the lineage module does not shade the spark, so I think the worst case is the lineage can not work and the engine won't be broken ?
we can add try-catch for those code in engine and narrow the exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3558:
URL: https://github.com/apache/kyuubi/pull/3558#issuecomment-1702304635
cc @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
iodone commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r999335604
##########
externals/kyuubi-spark-sql-engine/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
@yaooqinn Can we use `optional` dependencies here? Refer to the definition of maven `optional`:
> The idea is that some of the dependencies are only used for certain features in the project and will not be needed if that feature isn't used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on a diff in pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
iodone commented on code in PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#discussion_r982064857
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala:
##########
@@ -136,10 +142,25 @@ class PlanOnlyStatement(
case ExecutionMode =>
val executed = spark.sql(statement).queryExecution.executedPlan
iter = new IterableFetchIterator(Seq(Row(executed.toJSON)))
+ case LineageMode =>
+ val result = parseLineage(spark, plan)
+ iter = new IterableFetchIterator(Seq(Row(result)))
case UnknownMode => throw unknownModeError(mode)
case _ =>
throw KyuubiSQLException(s"The operation mode $mode" +
" doesn't support in Spark SQL engine.")
}
}
+
+ private def parseLineage(spark: SparkSession, plan: LogicalPlan): String = {
+ val analyzed = spark.sessionState.analyzer.execute(plan)
+ spark.sessionState.analyzer.checkAnalysis(analyzed)
Review Comment:
Call the`executeAndCheck` method in the `analyzed` stage when query execution, this method includes `checkAnalysis`, but here just call the `spark.sessionState.analyzer.execute(plan)`, so `optimized` don't do this check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#issuecomment-1272264618
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3558](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b0cf34) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/fb6516a588c9d00d4215b8459b05873f8747c20f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb6516a) will **decrease** coverage by `0.06%`.
> The diff coverage is `72.22%`.
> :exclamation: Current head 1b0cf34 differs from pull request most recent head 74a2783. Consider uploading reports for the commit 74a2783 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3558 +/- ##
============================================
- Coverage 51.79% 51.73% -0.07%
Complexity 13 13
============================================
Files 483 482 -1
Lines 26998 26993 -5
Branches 3769 3765 -4
============================================
- Hits 13983 13964 -19
- Misses 11655 11665 +10
- Partials 1360 1364 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ala/org/apache/kyuubi/operation/PlanOnlyMode.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vUGxhbk9ubHlNb2RlLnNjYWxh) | `37.20% <50.00%> (+0.62%)` | :arrow_up: |
| [...ubi/engine/spark/operation/PlanOnlyStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vUGxhbk9ubHlTdGF0ZW1lbnQuc2NhbGE=) | `47.47% <73.33%> (+5.80%)` | :arrow_up: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.34% <100.00%> (+<0.01%)` | :arrow_up: |
| [...la/org/apache/kyuubi/ctl/ControlCliException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvQ29udHJvbENsaUV4Y2VwdGlvbi5zY2FsYQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [.../kyuubi/server/mysql/constant/MySQLErrorCode.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvY29uc3RhbnQvTXlTUUxFcnJvckNvZGUuc2NhbGE=) | `13.84% <0.00%> (-6.16%)` | :arrow_down: |
| [...ache/kyuubi/server/mysql/MySQLCommandHandler.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxDb21tYW5kSGFuZGxlci5zY2FsYQ==) | `75.00% <0.00%> (-4.55%)` | :arrow_down: |
| [...main/scala/org/apache/kyuubi/ctl/cmd/Command.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL0NvbW1hbmQuc2NhbGE=) | `80.00% <0.00%> (-3.34%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `79.45% <0.00%> (-2.74%)` | :arrow_down: |
| [...ache/kyuubi/server/mysql/MySQLGenericPackets.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxHZW5lcmljUGFja2V0cy5zY2FsYQ==) | `76.59% <0.00%> (-2.13%)` | :arrow_down: |
| [...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2xvZy9Mb2dCYXRjaENvbW1hbmQuc2NhbGE=) | `78.00% <0.00%> (-2.00%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/3558/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #3558: [KYUUBI #3444] Support the planOnly mode of kyuubi spark engine support SQL lineage
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on PR #3558:
URL: https://github.com/apache/incubator-kyuubi/pull/3558#issuecomment-1272304364
the github action seems get sick.. every commit need approve to run : (
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org