You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/21 03:33:03 UTC
[GitHub] [incubator-devlake] matrixji opened a new issue, #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
matrixji opened a new issue, #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
1. Install/deploy devlake with helm chart. (Enable ingress)
2. And when ingress is enabled, the grafana dashboard will use a /grafana prefix for the URL.
3. Configure some pipelines to collect some data.
4. Some icon's URL is not visible(Grafana), see the below screenshot.
And I'm trying to modify the URL to a relative path(remove the leading /), and it seems to work, I'm not an expert on the frontend, so some frontend exports to fix it.
### What you expected to happen
The icons should be visible while deploying with helm as well as with NodePort.
### How to reproduce
See above
### Anything else
N/A
### Version
main
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] matrixji commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
matrixji commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1177260855
> > @matrixji which method？
>
> 1. Deploy with helm using ingress, and in such case, grafana will be published at https://domain/grafana/
> 2. Deploy with helm using NodePort, and in such case grafana will be published at http://domain:port/
> 3. Deploy local with docker-compose, and grafana will be published at http://127.0.0.1:3002/
I'm using helm with ingress, it' seems grafana could not support import JSON with the relative path in `src` here.
So maybe simply changing `/path` -> `path` in JSON is not a good solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1173309237
Note that in `config-ui/nginx.conf`, we have the following section:
```
location /grafana {
rewrite /grafana(.*)$ ${GRAFANA_ENDPOINT}$1;
}
```
which effectively redirect URL path starts with `/grafana` to another
host defined by `GRAFANA_ENDPOINT` environment variable of the
container, and the prefix `/grafana` would be trimmed. i.e.
let say, for `config-ui` container, the `GRAFANA_ENDPOINT` is set to
`http://grafana`.
when a user try to access `http://config-ui/grafana/hello_world`, he/she
would be redirected to `http://grafana/hello_world`
On 22/07/03 08:25PM, Ji Bin wrote:
> I'm using a Linux server to deploy for it, I have an M1 based Macbook, I'll try using `make configure-dev` on it to have more investigation.
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1173296828
> You are receiving this because you are subscribed to this thread.
>
> Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] matrixji commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
matrixji commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1175881039
Information updates. Retry with import JSON on grafana. After importing the modified JSON, the HTML element tree is shown below in devtool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] matrixji commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
matrixji commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179118338
> > > > @matrixji which method？
> > >
> > >
> > >
> > > 1. Deploy with helm using ingress, and in such case, grafana will be published at https://domain/grafana/
> > > 2. Deploy with helm using NodePort, and in such case grafana will be published at http://domain:port/
> > > 3. Deploy local with docker-compose, and grafana will be published at http://127.0.0.1:3002/
> >
> >
> > I'm using helm with ingress, it' seems grafana could not support import JSON with the relative path in `src` here. So maybe simply changing `/path` -> `path` in JSON is not a good solution.
>
> Okey, so do you think the helm installation method is not compatible with grafana? Need to change some configuration in helm to fix it or other?
Maybe, I'm not sure, I'd like to have some investigation on it to find a suitable solution, will be updated here later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179464926
Thanks for your work, very valuable.
I would discuss with others on Monday since it would affect the other
parts of the system.
On 22/07/08 09:14AM, Ji Bin wrote:
> Similar to this issue: https://github.com/grafana/grafana/issues/21400
> So my suggestion is proxy `http://domain/public/.*` -> `http://domain/grafana/public/.*`, and `http://domain/d/.*` -> `http://domain/grafana/d/.*`. Currently seems /public and /d are not used for config-ui.
>
> I've tested success with my demo site: https://devlake-0.jibin.net:8443/grafana/d/0Rjxknc7z/demo-homepage?orgId=1 (Not always available)
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179158813
> You are receiving this because you commented.
>
> Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] Startrekzky commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
Startrekzky commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1168158010
Thanks for issuing the bug @matrixji
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 closed issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
warren830 closed issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
URL: https://github.com/apache/incubator-devlake/issues/2279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
abeizn commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1175896422
> @matrixji which method？
1. Deploy with helm using ingress, and in such case, grafana will be published at https://domain/grafana/
2. Deploy with helm using NodePort, and in such case grafana will be published at http://domain:port/
3. Deploy local with docker-compose, and grafana will be published at http://127.0.0.1:3002/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] matrixji commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
matrixji commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179158813
Similar to this issue: https://github.com/grafana/grafana/issues/21400
So my suggestion is proxy `http://domain/public/.*` -> `http://domain/grafana/public/.*`, and `http://domain/d/.*` -> `http://domain/grafana/d/.*`. Currently seems /public and /d are not used for config-ui.
I've tested success with my demo site: https://devlake-0.jibin.net:8443/grafana/d/0Rjxknc7z/demo-homepage?orgId=1 (Not always available)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
abeizn commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1173254522
> I have some try deploying with 3 different methods by this weekend.
>
> * Deploy with helm using ingress, and in such case, grafana will be published at https://domain/grafana/
> * Deploy with helm using NodePort, and in such case grafana will be published at http://domain:port/
> * Deploy local with docker-compose, and grafana will be published at http://127.0.0.1:3002/
>
> For case 1 (helm with ingress), the grafana will finally have the below code in head.
>
> ```
> <base href="/grafana/">
> ```
>
> And for case 2/3, the code will be:
>
> ```
> <base href="/">
> ```
>
> So for my understanding change to `/public/img/lake/.png` to `public/img/lake/.png` should be OK for all cases.
I will try it, if "public/img/lake/.png" work, I will fix it, By the way, what OS are you？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
abeizn commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1173289047
Unfortunately, it doesn't work after I remove prefix "/" by "Deploy local with docker-compose"
This is my operation steps. my os is MacOs M1.
1. update /public/img/lake/.png to public/img/lake/.png
2. make dev, and make configure-dev
3. open grafana, import updated `DemoHomepage.json`, This is to make sure grafana is in effect.
4. I updated
"/public/img/lake/customer.png" to "public/img/lake/customer.png"
and
"/public/img/lake/demo_quality.png" to "public/img/lake/demo_quality.png"
in DemoHomePage.json.
6. results screenshots: customer and demo_quality do not work.
Can you make sure that the DemoHomePage.json in your grafana is up to date or correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] matrixji commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
matrixji commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1173296828
I'm using a Linux server to deploy for it, I have an M1 based Macbook, I'll try using `make configure-dev` on it to have more investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179465409
One more thing, would you mind summing up the whole situation and send a
mail to ***@***.*** for open discussion?
It would help a lot, Thanks in advance.
On 22/07/08 09:14AM, Ji Bin wrote:
> Similar to this issue: https://github.com/grafana/grafana/issues/21400
> So my suggestion is proxy `http://domain/public/.*` -> `http://domain/grafana/public/.*`, and `http://domain/d/.*` -> `http://domain/grafana/d/.*`. Currently seems /public and /d are not used for config-ui.
>
> I've tested success with my demo site: https://devlake-0.jibin.net:8443/grafana/d/0Rjxknc7z/demo-homepage?orgId=1 (Not always available)
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179158813
> You are receiving this because you commented.
>
> Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179465727
> ## Currently, seems /public and /d are not used for config-ui.
> Thank you for your suggestions. I don't quite understand what this sentence means? Does it mean that config-ui cannot be used after the change?
I think the whole point is to use `reverse proxying for grafana` instead of `redirecting to grafana`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
abeizn commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1177279149
> > > @matrixji which method？
> >
> >
> >
> > 1. Deploy with helm using ingress, and in such case, grafana will be published at https://domain/grafana/
> > 2. Deploy with helm using NodePort, and in such case grafana will be published at http://domain:port/
> > 3. Deploy local with docker-compose, and grafana will be published at http://127.0.0.1:3002/
>
> I'm using helm with ingress, it' seems grafana could not support import JSON with the relative path in `src` here. So maybe simply changing `/path` -> `path` in JSON is not a good solution.
Okey, so do you think the helm installation method is not compatible with grafana?
Need to change some configuration in helm to fix it or other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
abeizn commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1172162307
@matrixji
1. "image: mericodev/grafana:latest" , when user push the latest tag(https://hub.docker.com/r/mericodev/grafana/tags)，the image will be updated. same is apache images and some is devlake images, so the problem is coming.
2. update " /public/img/lake/*.png " to " public/img/lake/*.png ", i try it. But it does not work. maybe it's due to cookie.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] matrixji commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
matrixji commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1173124041
I have some try deploying with 3 different methods by this weekend.
- Deploy with helm using ingress, and in such case, grafana will be published at https://domain/grafana/
- Deploy with helm using NodePort, and in such case grafana will be published at http://domain:port/
- Deploy local with docker-compose, and grafana will be published at http://127.0.0.1:3002/
For case 1 (helm with ingress), the grafana will finally have the below code in head.
```html
<base href="/grafana/">
```
And for case 2/3, the code will be:
```html
<base href="/">
```
So for my understanding change to `/public/img/lake/.png` to `public/img/lake/.png` should be OK for all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] matrixji commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
matrixji commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1185347943
Information for helm deployment:
Tested with master helm chart, it shows the Icons in default grafana's Home. So no adaptation is needed for the helm chart.
The screen shot for deploy with helm and grafana in latest master:
<img width="1048" alt="截屏2022-07-15 17 13 53" src="https://user-images.githubusercontent.com/183388/179193382-38810b5b-98ec-439f-a82c-e076f6a1bede.png">
Great thanks for all guys handling this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] abeizn commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
abeizn commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179439414
Currently, seems /public and /d are not used for config-ui.
----------------------------------------------------------
Thank you for your suggestions. I don't quite understand what this sentence means? Does it mean that config-ui cannot be used after the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #2279: [Bug][grafana] The customized icon not showing, while visit grafana dashboard with the url /prefix
Posted by GitBox <gi...@apache.org>.
klesh commented on issue #2279:
URL: https://github.com/apache/incubator-devlake/issues/2279#issuecomment-1179150196
Looking forward to the solution 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org