You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/05 07:47:02 UTC

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #3660: stm32_pwm: improvements for PULSECOUNT support

raiden00pl opened a new pull request #3660:
URL: https://github.com/apache/incubator-nuttx/pull/3660


   ## Summary
   - drivers/timers/pwm.c: fix compilation warnings
   - stm32_pwm.c: fix compilation warnings
   - stm32_pwm: fixes for PULSECOUNT support:
       1. generate an indefinite number of pulses when info->count = 0
       2. timers that don't support pulse-count shouldn't use pulse-count logic
   
   ## Impact
   
   ## Testing
   PWM example on nucleo-f446re with TIM1 PWM and TIM2 PWM enabled.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #3660: stm32_pwm: improvements for PULSECOUNT support

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3660:
URL: https://github.com/apache/incubator-nuttx/pull/3660#issuecomment-832959442


   Thanks @acassis 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #3660: stm32_pwm: improvements for PULSECOUNT support

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3660:
URL: https://github.com/apache/incubator-nuttx/pull/3660


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 commented on pull request #3660: stm32_pwm: improvements for PULSECOUNT support

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3660:
URL: https://github.com/apache/incubator-nuttx/pull/3660#issuecomment-832559887


   @raiden00pl Was @DisruptiveNL going to test this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #3660: stm32_pwm: improvements for PULSECOUNT support

Posted by GitBox <gi...@apache.org>.
raiden00pl commented on pull request #3660:
URL: https://github.com/apache/incubator-nuttx/pull/3660#issuecomment-832639472


   @davids5 I think we can merge this now and if @DisruptiveNL finds any problem I'll deal with it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org