You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/12/29 06:50:41 UTC
[GitHub] zeppelin pull request #1814: [ZEPPELIN-1869] changed the API response to gen...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1814
[ZEPPELIN-1869] changed the API response to generate to 200.
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Documentation | change
### Todos
- [x] replace to doc
- [x] change response 201 -> 200
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1869
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-STATUS-CHANGE-API
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1814.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1814
----
commit 754309ed4c68e408e48a95d53a460d80fc2935f9
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T06:42:07Z
Apply to api success status code 200
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1814: [ZEPPELIN-1869] changed the API response to gen...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1814
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1814: [ZEPPELIN-1869] changed the API response to gen...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1814
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1814: [ZEPPELIN-1869] changed the API response to generate t...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1814
@Leemoonsoo Ah! sorry, i will fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1814: [ZEPPELIN-1869] changed the API response to gen...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1814
[ZEPPELIN-1869] changed the API response to generate to 200.
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Documentation | change
### Todos
- [x] replace to doc
- [x] change response 201 -> 200
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1869
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-STATUS-CHANGE-API
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1814.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1814
----
commit 754309ed4c68e408e48a95d53a460d80fc2935f9
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T06:42:07Z
Apply to api success status code 200
commit ed317886f250c246734bb9a947d0bcdfaa352f9b
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T07:55:08Z
refix
commit f9fcbc8fbd5a4d6686c0ef4f033694365372deaa
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T07:58:58Z
Revert "refix"
This reverts commit ed317886f250c246734bb9a947d0bcdfaa352f9b.
commit 7bbfcd1c24af196c596178a57e2dde33d279956e
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-07T09:01:30Z
change status value in test case http
commit cfcb6fdbe84c92a41e987ad0f026c9b47c517c47
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-07T09:30:12Z
change test case in zeppelin rest api test
commit 1be096822d15ee84786597dc83f5523375abc284
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-07T09:59:50Z
fixed more isCreated to isAllowed
commit 0f2f5bd74630dcc9702d0ecb30b86e483cb4f965
Author: cloverhearts <cl...@gmail.com>
Date: 2017-01-07T10:45:59Z
change test case in notebooksecurity
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1814: [ZEPPELIN-1869] changed the API response to gen...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1814
[ZEPPELIN-1869] changed the API response to generate to 200.
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Documentation | change
### Todos
- [x] replace to doc
- [x] change response 201 -> 200
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1869
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-STATUS-CHANGE-API
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1814.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1814
----
commit 754309ed4c68e408e48a95d53a460d80fc2935f9
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T06:42:07Z
Apply to api success status code 200
commit ed317886f250c246734bb9a947d0bcdfaa352f9b
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T07:55:08Z
refix
commit f9fcbc8fbd5a4d6686c0ef4f033694365372deaa
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T07:58:58Z
Revert "refix"
This reverts commit ed317886f250c246734bb9a947d0bcdfaa352f9b.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1814: [ZEPPELIN-1869] changed the API response to generate t...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1814
Fixed done.
CI is green :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1814: [ZEPPELIN-1869] changed the API response to gen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1814
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1814: [ZEPPELIN-1869] changed the API response to generate t...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1814
@cloverhearts I think you need update related unittests, too.
```
Results :
Failed tests:
InterpreterRestApiTest.testAddDeleteRepository:352 Test create method:
Expected: HTTP response <201> from /api/interpreter/repository/
but: got <200> OK
InterpreterRestApiTest.testCreatedInterpreterDependencies:171 test create method:
Expected: HTTP response <201> from /api/interpreter/setting
but: got <200> OK
InterpreterRestApiTest.testSettingsCRUD:124 test create method:
Expected: HTTP response <201> from /api/interpreter/setting/
but: got <200> OK
ZeppelinRestApiTest.testCloneNote:329 test note clone method:
Expected: HTTP response <201> from /api/notebook/2C7FSPHN2
but: got <200> OK
ZeppelinRestApiTest.testImportNotebook:265
Expected: HTTP response <201> from /api/notebook/import/
but: got <200> OK
ZeppelinRestApiTest.testInsertParagraph:593 Test insert method:
Expected: HTTP response <201> from /api/notebook/2C6FACAQZ/paragraph
but: got <200> OK
ZeppelinRestApiTest.testNoteCreateNoName:127->testNoteCreate:175 test note create method:
Expected: HTTP response <201> from /api/notebook/
but: got <200> OK
ZeppelinRestApiTest.testNoteCreateWithName:122->testNoteCreate:175 test note create method:
Expected: HTTP response <201> from /api/notebook/
but: got <200> OK
ZeppelinRestApiTest.testNoteCreateWithParagraphs:140 test note create method:
Expected: HTTP response <201> from /api/notebook/
but: got <200> OK
NotebookRestApiTest.testCloneNote:129
Expected: HTTP response <201> from /api/notebook/2C6JVYEJD
but: got <200> OK
NotebookSecurityRestApiTest.testThatOtherUserCannotAccessNoteIfPermissionSet:81->createNoteForUser:155 test note create method:
Expected: HTTP response <201> from /api/notebook/
but: got <200> OK
NotebookSecurityRestApiTest.testThatUserCanSearchNote:115->createNoteForUser:155 test note create method:
Expected: HTTP response <201> from /api/notebook/
but: got <200> OK
NotebookSecurityRestApiTest.testThatWriterCannotRemoveNote:98->createNoteForUser:155 test note create method:
Expected: HTTP response <201> from /api/notebook/
but: got <200> OK
NotebookSecurityRestApiTest.testThatOtherUserCanAccessNoteIfPermissionNotSet:72->createNoteForUser:155 test note create method:
Expected: HTTP response <201> from /api/notebook/
but: got <200> OK
NotebookSecurityRestApiTest.testThatUserCanCreateAndRemoveNote:63->createNoteForUser:155 test note create method:
Expected: HTTP response <201> from /api/notebook/
but: got <200> OK
Tests run: 82, Failures: 15, Errors: 0, Skipped: 1
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1814: [ZEPPELIN-1869] changed the API response to generate t...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1814
LGTM. Will merge if there's no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---