You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/21 09:26:07 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5049: Update IFF_RUNNING flag by netdev_carrier_on and netdev_carrier_off

xiaoxiang781216 opened a new pull request #5049:
URL: https://github.com/apache/incubator-nuttx/pull/5049


   ## Summary
   
   - sim/netdev: Update IFF_RUNNING flag by netdev_carrier_on and netdev_carrier_off
   - net/loopback: Update IFF_RUNNING flag by netdev_carrier_on and netdev_carrier_off
   - net/tun: Update IFF_RUNNING flag by netdev_carrier_on and netdev_carrier_off
   - net/slip: Update IFF_RUNNING flag by netdev_carrier_on and netdev_carrier_off
   
   ## Impact
   
   running flag reflect the carrier state correctly for the pseudo netdev.
   
   ## Testing
   
   Pass CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #5049: Update IFF_RUNNING flag by netdev_carrier_on and netdev_carrier_off

Posted by GitBox <gi...@apache.org>.

gustavonihei commented on pull request #5049:
URL: https://github.com/apache/incubator-nuttx/pull/5049#issuecomment-998809102


   How about the other `net` drivers? It seems this fix could also be extended to them.
   At least we should create an issue for not losing track of it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5049: Update IFF_RUNNING flag by netdev_carrier_on and netdev_carrier_off

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 commented on pull request #5049:
URL: https://github.com/apache/incubator-nuttx/pull/5049#issuecomment-999375836


   > How about the other `net` drivers? It seems this fix could also be extended to them. 
   
   Yes, the real driver need monitor the carrier change interrupt and report the real state correctly, but since it 's hardware dependent, I can't skimpily modify directly.
   
   > At least we should create an issue for not losing track of it.
   
   It's here: https://github.com/apache/incubator-nuttx/issues/5059


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei merged pull request #5049: Update IFF_RUNNING flag by netdev_carrier_on and netdev_carrier_off

Posted by GitBox <gi...@apache.org>.

gustavonihei merged pull request #5049:
URL: https://github.com/apache/incubator-nuttx/pull/5049


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org