You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Divyansh200102 (via GitHub)" <gi...@apache.org> on 2023/10/15 19:38:12 UTC
[PR] fix reStructuredText link markup [arrow]
Divyansh200102 opened a new pull request, #38276:
URL: https://github.com/apache/arrow/pull/38276
fixes #35369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 closed pull request #38276: GH-35369: [Docs] updated ref:`IPC <format-ipc>` to ref:`IPC format <format-ipc>'
URL: https://github.com/apache/arrow/pull/38276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369:[Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38276:
URL: https://github.com/apache/arrow/pull/38276#discussion_r1362968295
##########
docs/source/java/vector_schema_root.rst:
##########
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
-`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
+`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC format <format-ipc>`
Review Comment:
ditto.
https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot
> (a representation of a RecordBatch [IPC](https://arrow.apache.org/docs/format/Columnar.html#format-ipc) message)
##########
docs/source/developers/overview.rst:
##########
@@ -184,7 +184,7 @@ implementation can support:
same endianness). This includes ancillary functionality such as reading
and writing various file formats, such as Parquet.
2. Cross endian support (implementations will do byte reordering when
- appropriate for :ref:`IPC <format-ipc>` and :ref:`Flight <flight-rpc>`
+ appropriate for :ref:`IPC format <format-ipc>` and :ref:`Flight <flight-rpc>`
Review Comment:
ditto.
https://arrow.apache.org/docs/developers/overview.html#endianness
> (implementations will do byte reordering when appropriate for [IPC](https://arrow.apache.org/docs/format/Columnar.html#format-ipc) and...
##########
docs/source/cpp/tables.rst:
##########
@@ -82,7 +82,7 @@ and computation functions, possibly incremental.
structure as described in text above.
Record batches can be sent between implementations, such as via
-:ref:`IPC <format-ipc>` or
+:ref:`IPC format <format-ipc>` or
Review Comment:
Is this really needed?
https://arrow.apache.org/docs/cpp/tables.html#record-batches renders correctly without this:
> Record batches can be sent between implementations, such as via [IPC](https://arrow.apache.org/docs/format/Columnar.html#format-ipc) or via ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix reStructuredText link markup [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1763569640
Could you read the auto-generated comment?
https://github.com/apache/arrow/pull/38276#issuecomment-1763484822
And could you read our pull request template and follow it instead of remove it entirely without reading it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix reStructuredText link markup [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1763484822
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1770217950
@raulcd
i am encountering this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #38276:
URL: https://github.com/apache/arrow/pull/38276#discussion_r1461614700
##########
docs/source/format/Glossary.rst:
##########
@@ -174,7 +174,7 @@ Glossary
.. seealso:: :term:`data type`
record batch
- **In the :ref:`IPC format <format-ipc>`**: the primitive unit
+ **In the :ref:`IPC format <format-ipc>` **: the primitive unit
Review Comment:
It looks like a link in the bold text is not supported so I would do this:
```suggestion
**In the** :ref:`IPC format <format-ipc>`: the primitive unit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1902274505
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Fix reST markup around ref:`IPC format ` [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1905063450
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 315e06ae5b5733727696dd5a1298dcbb0e9ae6f0.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/20751537314) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #38276:
URL: https://github.com/apache/arrow/pull/38276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1904079733
Revision: 8d294b7058f72cbbc6b0c0b6b46e7edf208d6d08
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b2a30f86b0](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b2a30f86b0)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/7612379104/job/20729867210)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1904244475
Revision: 37e8fdc11dba543f5680e49c088b9d7b36f6c18c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-04924a384c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-04924a384c)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/7613474640/job/20733444443)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1904237471
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1770221916
@raulcd i am encountering this
<script src="https://gist.github.com/Divyansh200102/7e26fc47fd2f66a438970c5d8f1fae4f.js"></script>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1767854847
> Could you check your change on local? See also: https://arrow.apache.org/docs/developers/documentation.html#building-with-docker
>
> I think that the following is the needed change:
>
> ```diff
> diff --git a/docs/source/format/Glossary.rst b/docs/source/format/Glossary.rst
> index 65d6e0afa..d0adc0cc3 100644
> --- a/docs/source/format/Glossary.rst
> +++ b/docs/source/format/Glossary.rst
> @@ -174,7 +174,7 @@ Glossary
> .. seealso:: :term:`data type`
>
> record batch
> - **In the :ref:`IPC format <format-ipc>`**: the primitive unit
> + **In the :ref:`IPC format <format-ipc>` **: the primitive unit
> of data. A record batch consists of an ordered list of
> :term:`buffers <buffer>` corresponding to a :term:`schema`.
>
> ```
hi, @kou i am trying to setup the project using the docker-compose.yml file by using the command "docker compose up -d" but this is error is showing up (Error response from daemon: manifest for amd64/maven:3.5.4-eclipse-temurin-8 not found: manifest unknown: manifest unknown) i think this version of amd64/maven is not in the registry .i tried pulling manually as well but still nothing can you help me out to solve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on code in PR #38276:
URL: https://github.com/apache/arrow/pull/38276#discussion_r1460673928
##########
docs/source/java/vector_schema_root.rst:
##########
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
-`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
+`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
Review Comment:
Done @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on code in PR #38276:
URL: https://github.com/apache/arrow/pull/38276#discussion_r1462023011
##########
docs/source/format/Glossary.rst:
##########
@@ -174,7 +174,7 @@ Glossary
.. seealso:: :term:`data type`
record batch
- **In the :ref:`IPC format <format-ipc>`**: the primitive unit
+ **In the** :ref:`IPC format <format-ipc>`: the primitive unit
Review Comment:
```suggestion
**In the** :ref:`IPC format <format-ipc>`: the primitive unit
```
Sorry, one space is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1768194878
BTW if you are trying to build the documentation locally here is the documentation: https://arrow.apache.org/docs/developers/documentation.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1770421880
Hi @Divyansh200102 , it seems to be failing on building pygit2 which is a dependency for Archery:
```
Failed to build pygit2
ERROR: Could not build wheels for pygit2, which is required to install pyproject.toml-based projects
```
I am not entirely sure what the problem is with the logs provided but you are probably using Python 3.12 and that's why there are no wheels available yet for them as seen on PyPI: https://pypi.org/project/pygit2/#files
If you want to build from source you'll need to follow their installation guide requirements for Windows: https://www.pygit2.org/install.html#installing-on-windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1902484883
@AlenkaF Could you help us for reST markup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1902223720
Please review the changes @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1768191570
Hi @Divyansh200102 we use docker-compose as a utility to help us run different testing containers mainly for CI and some locally but we don't use `docker-compose up` as we have lots of images and this is not supposed to work.
Due to the large amount of languages and tools in the Apache Arrow repository we have in this contribution guide several examples on how to build and test locally for the different languages. Please take a look there and don't hesitate on asking if something is not clear enough: https://arrow.apache.org/docs/dev/developers/guide/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1770227243
@raulcd i am encountering this
https://gist.github.com/Divyansh200102/7e26fc47fd2f66a438970c5d8f1fae4f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1770241294
i am encountering this @raulcd
https://gist.github.com/Divyansh200102/7e26fc47fd2f66a438970c5d8f1fae4f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on code in PR #38276:
URL: https://github.com/apache/arrow/pull/38276#discussion_r1460670794
##########
docs/source/java/vector_schema_root.rst:
##########
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
-`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
+`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
Review Comment:
So shall I remove this line no 110?
> It seems that we don't need this:
>
> https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot
>
> > [ArrowRecordBatch](https://arrow.apache.org/docs/java/reference/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.html) (a representation of a RecordBatch [IPC](https://arrow.apache.org/docs/format/Columnar.html#format-ipc) message).
So shall I remove line no 110?
##########
docs/source/java/vector_schema_root.rst:
##########
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
-`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
+`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
Review Comment:
So shall I remove this line no 110?
> It seems that we don't need this:
>
> https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot
>
> > [ArrowRecordBatch](https://arrow.apache.org/docs/java/reference/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.html) (a representation of a RecordBatch [IPC](https://arrow.apache.org/docs/format/Columnar.html#format-ipc) message).
So shall I remove line no 110?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on code in PR #38276:
URL: https://github.com/apache/arrow/pull/38276#discussion_r1460670961
##########
docs/source/java/vector_schema_root.rst:
##########
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
-`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
+`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
Review Comment:
> It seems that we don't need this:
>
> https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot
>
> > [ArrowRecordBatch](https://arrow.apache.org/docs/java/reference/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.html) (a representation of a RecordBatch [IPC](https://arrow.apache.org/docs/format/Columnar.html#format-ipc) message).
So shall I remove line no 110?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on code in PR #38276:
URL: https://github.com/apache/arrow/pull/38276#discussion_r1460670961
##########
docs/source/java/vector_schema_root.rst:
##########
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
-`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
+`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
Review Comment:
> It seems that we don't need this:
>
> https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot
>
> > [ArrowRecordBatch](https://arrow.apache.org/docs/java/reference/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.html) (a representation of a RecordBatch [IPC](https://arrow.apache.org/docs/format/Columnar.html#format-ipc) message).
So shall I remove line no 110?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1771048591
> Hi @Divyansh200102 , it seems to be failing on building pygit2 which is a dependency for Archery:
>
> ```
> Failed to build pygit2
> ERROR: Could not build wheels for pygit2, which is required to install pyproject.toml-based projects
> ```
>
> I am not entirely sure what the problem is with the logs provided but you are probably using Python 3.12 and that's why there are no wheels available yet for them as seen on PyPI: https://pypi.org/project/pygit2/#files If you want to build from source you'll need to follow their installation guide requirements for Windows: https://www.pygit2.org/install.html#installing-on-windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1770229124
@raulcd i am encountering this
https://gist.github.com/Divyansh200102/7e26fc47fd2f66a438970c5d8f1fae4f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1770223462
[](<script src="https://gist.github.com/Divyansh200102/7e26fc47fd2f66a438970c5d8f1fae4f.js"></script>)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ' [arrow]
Posted by "Divyansh200102 (via GitHub)" <gi...@apache.org>.
Divyansh200102 commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1772202453
@raulcd please see this https://gist.github.com/Divyansh200102/3ba4f5e391d8e62307f8b584a5a659d8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] updated ref:`IPC ` to ref:`IPC format ` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38276:
URL: https://github.com/apache/arrow/pull/38276#discussion_r1460669899
##########
docs/source/java/vector_schema_root.rst:
##########
@@ -107,7 +107,7 @@ Here is an example of creating a VectorSchemaRoot:
Data can be loaded into/unloaded from a VectorSchemaRoot via `VectorLoader`_
and `VectorUnloader`_. They handle converting between VectorSchemaRoot and
-`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
+`ArrowRecordBatch`_ (a representation of a RecordBatch :ref:`IPC <format-ipc>`
Review Comment:
It seems that we don't need this:
https://arrow.apache.org/docs/java/vector_schema_root.html#vectorschemaroot
> [ArrowRecordBatch](https://arrow.apache.org/docs/java/reference/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.html) (a representation of a RecordBatch [IPC](https://arrow.apache.org/docs/format/Columnar.html#format-ipc) message).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1902274889
Revision: b934b666cf6c9abb937938229ae429d68465db7c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3dedf8ca9e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3dedf8ca9e)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/7597045837/job/20691443926)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1902484706
Hmm. The "IPC format" link markup is solved but the `** ... **` mark is broken...
http://crossbow.voltrondata.com/pr_docs/38276/format/Glossary.html#term-record-batch
> [**](http://crossbow.voltrondata.com/pr_docs/38276/format/Glossary.html#id1)In the [IPC format](http://crossbow.voltrondata.com/pr_docs/38276/format/Columnar.html#format-ipc) [**](http://crossbow.voltrondata.com/pr_docs/38276/format/Glossary.html#id3): the primitive unit of data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35369: [Docs] Add a missing space after ref:`IPC format ` [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38276:
URL: https://github.com/apache/arrow/pull/38276#issuecomment-1904074873
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org