You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2019/12/09 00:57:13 UTC

[commons-numbers] branch master updated: Exclude check for equality with positive infinity in Complex sqrt.

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git


The following commit(s) were added to refs/heads/master by this push:
     new e804844  Exclude check for equality with positive infinity in Complex sqrt.
e804844 is described below

commit e804844ff7c75f1d335141272fe38cf09579e7f8
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Mon Dec 9 00:57:10 2019 +0000

    Exclude check for equality with positive infinity in Complex sqrt.
---
 src/main/resources/spotbugs/spotbugs-exclude-filter.xml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
index d533776..5d18f8e 100644
--- a/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
+++ b/src/main/resources/spotbugs/spotbugs-exclude-filter.xml
@@ -26,11 +26,16 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="https://github.com/spotbugs/filter/3.1.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
 
+  <!-- Deliberately floating-point equality checks. -->
   <Match>
-    <!-- The Brent method deliberately checks equality. -->
     <Class name="org.apache.commons.numbers.rootfinder.BrentSolver"/>
     <Method name="brent"/>
     <BugPattern name="FE_FLOATING_POINT_EQUALITY"/>
   </Match>
+  <Match>
+    <Class name="org.apache.commons.numbers.complex.Complex"/>
+    <Method name="sqrt"/>
+    <BugPattern name="FE_FLOATING_POINT_EQUALITY"/>
+  </Match>
 
 </FindBugsFilter>