You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/12/02 03:03:19 UTC
[kudu-CR](branch-1.6.x) [client] expose non-voter replicas for kudu CLI tool
Hello Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8733
to review the following change.
Change subject: [client] expose non-voter replicas for kudu CLI tool
......................................................................
[client] expose non-voter replicas for kudu CLI tool
Added private interface to expose non-voter replica in the kudu CLI
tools. Also, use that functionality to list table's replicas.
Updated output of ksck to include information on non-voters replicas:
* renamed column 'Voters' into 'Replicas'
* a non-voter is displayed with '~' extra suffix, e.g. in the example
below two non-voter replicas, B and C, are in the config along with
leader replica A:
Config source | Replicas | Current term | Config index | Committed?
---------------+--------------+--------------+--------------+-----------
master | A* B~ C~ | | | Yes
A | A* B~ C~ | 4 | 5 | Yes
B | A* B~ C~ | 4 | 5 | Yes
C | A* B~ C~ | 4 | 5 | Yes
I also updated the format of output to make it more readable. An
example of new output for 'kudu table list --list_tablets':
loadgen_auto_1e5f57a73dd34fa7bde7465219bd1866
T 69e22ffecb5b459db8a7fbf2f751a76f
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
N f2e726948d3143e184097cd953dd2230 127.0.0.1:9878
N 3ae7fdf107cf424dbf9c5e33c33eafd0 127.0.0.1:9876
T 662bae40e4ec46588e90670bec16b2b5
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
T 5ba95da9b2f9455db9d690bdd35ae5cb
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874
T 528ae88cce1e4415a0d075dead5c983c
L 20e66417713446039c22987fec13b800 127.0.0.1:9870
T 157ea108357e469e8fee001aec521d7e
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
T 9c6a4d493fff4bda9bfe8f158cb08e69
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
T 36d03adab6ad494ea4e769ef92ef5577
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874
T 7ce6d42984734614bd627d872e99c833
L 20e66417713446039c22987fec13b800 127.0.0.1:9870
Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Reviewed-on: http://gerrit.cloudera.org:8080/8586
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.cc
M src/kudu/client/client_builder-internal.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
A src/kudu/client/replica_controller-internal.cc
A src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
19 files changed, 429 insertions(+), 150 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/8733/1
--
To view, visit http://gerrit.cloudera.org:8080/8733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8733
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.6.x) [client] expose non-voter replicas for kudu CLI tool
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8733 )
Change subject: [client] expose non-voter replicas for kudu CLI tool
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8733
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 02 Dec 2017 05:21:31 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) [client] expose non-voter replicas for kudu CLI tool
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8733 )
Change subject: [client] expose non-voter replicas for kudu CLI tool
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8733
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 02 Dec 2017 05:28:57 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) [client] expose non-voter replicas for kudu CLI tool
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8733 )
Change subject: [client] expose non-voter replicas for kudu CLI tool
......................................................................
[client] expose non-voter replicas for kudu CLI tool
Added private interface to expose non-voter replica in the kudu CLI
tools. Also, use that functionality to list table's replicas.
Updated output of ksck to include information on non-voters replicas:
* renamed column 'Voters' into 'Replicas'
* a non-voter is displayed with '~' extra suffix, e.g. in the example
below two non-voter replicas, B and C, are in the config along with
leader replica A:
Config source | Replicas | Current term | Config index | Committed?
---------------+--------------+--------------+--------------+-----------
master | A* B~ C~ | | | Yes
A | A* B~ C~ | 4 | 5 | Yes
B | A* B~ C~ | 4 | 5 | Yes
C | A* B~ C~ | 4 | 5 | Yes
I also updated the format of output to make it more readable. An
example of new output for 'kudu table list --list_tablets':
loadgen_auto_1e5f57a73dd34fa7bde7465219bd1866
T 69e22ffecb5b459db8a7fbf2f751a76f
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
N f2e726948d3143e184097cd953dd2230 127.0.0.1:9878
N 3ae7fdf107cf424dbf9c5e33c33eafd0 127.0.0.1:9876
T 662bae40e4ec46588e90670bec16b2b5
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
T 5ba95da9b2f9455db9d690bdd35ae5cb
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874
T 528ae88cce1e4415a0d075dead5c983c
L 20e66417713446039c22987fec13b800 127.0.0.1:9870
T 157ea108357e469e8fee001aec521d7e
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
T 9c6a4d493fff4bda9bfe8f158cb08e69
L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872
T 36d03adab6ad494ea4e769ef92ef5577
L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874
T 7ce6d42984734614bd627d872e99c833
L 20e66417713446039c22987fec13b800 127.0.0.1:9870
Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Reviewed-on: http://gerrit.cloudera.org:8080/8586
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-on: http://gerrit.cloudera.org:8080/8733
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Mike Percy <mp...@apache.org>
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/client_builder-internal.cc
M src/kudu/client/client_builder-internal.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/replica-internal.cc
M src/kudu/client/replica-internal.h
A src/kudu/client/replica_controller-internal.cc
A src/kudu/client/replica_controller-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
19 files changed, 429 insertions(+), 150 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Mike Percy: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/8733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8733
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR](branch-1.6.x) [client] expose non-voter replicas for kudu CLI tool
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8733 )
Change subject: [client] expose non-voter replicas for kudu CLI tool
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.6.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8733
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 02 Dec 2017 04:01:47 +0000
Gerrit-HasComments: No