You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by John Kordich via Review Board <no...@reviews.apache.org> on 2017/04/13 18:45:53 UTC
Review Request 58430: Changed some failing Base64 tests to use 'u8'
string literals.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58430/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Changed some failing Base64 tests to use 'u8' string literals.
Diffs
-----
3rdparty/stout/tests/base64_tests.cpp 0473221abb352195e03ae970709eadcfc44d77b0
Diff: https://reviews.apache.org/r/58430/diff/1/
Testing
-------
Ran make check on Linux and ran stout-tests on Windows.
Thanks,
John Kordich
Re: Review Request 58430: Changed some failing Base64 tests to use
'u8' string literals.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58430/#review171973
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On April 13, 2017, 11:48 a.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58430/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 11:48 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7236
> https://issues.apache.org/jira/browse/MESOS-7236
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed some failing Base64 tests to use 'u8' string literals.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/base64_tests.cpp 0473221abb352195e03ae970709eadcfc44d77b0
>
>
> Diff: https://reviews.apache.org/r/58430/diff/1/
>
>
> Testing
> -------
>
> Ran make check on Linux and ran stout-tests on Windows.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 58430: Changed some failing Base64 tests to use
'u8' string literals.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58430/#review171923
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58430]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 13, 2017, 6:48 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58430/
> -----------------------------------------------------------
>
> (Updated April 13, 2017, 6:48 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Bugs: MESOS-7236
> https://issues.apache.org/jira/browse/MESOS-7236
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed some failing Base64 tests to use 'u8' string literals.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/base64_tests.cpp 0473221abb352195e03ae970709eadcfc44d77b0
>
>
> Diff: https://reviews.apache.org/r/58430/diff/1/
>
>
> Testing
> -------
>
> Ran make check on Linux and ran stout-tests on Windows.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 58430: Changed some failing Base64 tests to use
'u8' string literals.
Posted by John Kordich via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58430/
-----------------------------------------------------------
(Updated April 13, 2017, 6:48 p.m.)
Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
Changes
-------
These changes will fix the unit test failures on Windows by making sure that the string literals are encoded into bytes identically across platforms.
Bugs: MESOS-7236
https://issues.apache.org/jira/browse/MESOS-7236
Repository: mesos
Description
-------
Changed some failing Base64 tests to use 'u8' string literals.
Diffs
-----
3rdparty/stout/tests/base64_tests.cpp 0473221abb352195e03ae970709eadcfc44d77b0
Diff: https://reviews.apache.org/r/58430/diff/1/
Testing
-------
Ran make check on Linux and ran stout-tests on Windows.
Thanks,
John Kordich