[xalan-java] branch master updated: Revert default indent-amount

[mu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mukulg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/xalan-java.git


The following commit(s) were added to refs/heads/master by this push:
     new 6f418abf Revert default indent-amount
     new 690bd044 Merge pull request #5 from jkesselm/master
6f418abf is described below

commit 6f418abfacd11c9679ae985b6c9a333f0256417b
Author: Joe Kesselman <13...@users.noreply.github.com>
AuthorDate: Tue Jun 13 14:23:54 2023 -0400

    Revert default indent-amount
    
    Comments in file.
---
 src/org/apache/xml/serializer/output_xml.properties | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/org/apache/xml/serializer/output_xml.properties b/src/org/apache/xml/serializer/output_xml.properties
index a5a9470b..237121e6 100644
--- a/src/org/apache/xml/serializer/output_xml.properties
+++ b/src/org/apache/xml/serializer/output_xml.properties
@@ -40,8 +40,16 @@ media-type=text/xml
 #              xalan:content-handler="MyContentHandler"/>
 #  ...
 # Note that the colon after the protocol needs to be escaped.
-# {http\u003a//xml.apache.org/xalan}indent-amount=0
-{http\u003a//xml.apache.org/xalan}indent-amount=2
+#
+# NOTE: Any change to formatting may break existing code  which depends
+# upon the previous default formatting. True, nobody likes the
+# default of 0, but it's been there for two decades now and there is
+# probably a LOT of code which expects it. Since the current behavior
+# is not a bug, we really should at least try to census the user community
+# on that before altering it. Not that our test suite is a perfect
+# example of sensitivity to formatting. If we're going to alter it we should
+# simultaneously update the tests and/or test framework to reflect it.
+{http\u003a//xml.apache.org/xalan}indent-amount=0
 {http\u003a//xml.apache.org/xalan}content-handler=org.apache.xml.serializer.ToXMLStream
 {http\u003a//xml.apache.org/xalan}entities=org/apache/xml/serializer/XMLEntities
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xalan.apache.org
For additional commands, e-mail: commits-help@xalan.apache.org