[jira] [Resolved] (AMQ-5597) AMQP: clean up durable subscription unsubscribe handling to simplify and resolve issues

["Timothy Bish (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Bish resolved AMQ-5597.
-------------------------------
    Resolution: Fixed
      Assignee: Timothy Bish

AMQP receivers can now close with detach = true to leave a subscription in place, or close the link to remove the subscription.  Durable subscribers reattach by using the same container ID and naming the link using the subscription with a null source set, the broker will lookup the subscription and return a properly configured source or return an error to indicate that none was found. 

> AMQP: clean up durable subscription unsubscribe handling to simplify and resolve issues
> ---------------------------------------------------------------------------------------
>
>                 Key: AMQ-5597
>                 URL: https://issues.apache.org/jira/browse/AMQ-5597
>             Project: ActiveMQ
>          Issue Type: Sub-task
>          Components: AMQP
>    Affects Versions: 5.11.0, 5.11.1
>            Reporter: Robbie Gemmell
>            Assignee: Timothy Bish
>             Fix For: 5.12.0
>
>         Attachments: AMQ-5597.patch, AMQ-5597_v2.patch
>
>
> The current unsubscribe processing is identifying a 'null-source lookup' attach as indication to immediately unsubscribe a durable subscription, performing some trickery with capabilities. There are actually many other reasons reasons a client might do this type of attach, which might lead to prematurely ending a subscription. Fully closing (rather than a non-closing detach) the durable subscription link is to be the signal ending the subscription. The related code should be fixed to resolve this, and generally cleaned up to simplify things.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)