[GitHub] [hbase] GeorryHuang commented on a change in pull request #1292: HBASE-23994:Add WebUI to Canary

[GitBox <gi...@apache.org>]

GeorryHuang commented on a change in pull request #1292: HBASE-23994:Add WebUI to Canary
URL: https://github.com/apache/hbase/pull/1292#discussion_r406207571
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java
 ##########
 @@ -274,16 +303,50 @@ public void publishReadTiming(String znode, String server, long msTime) {
     private Map<String, LongAdder> perTableReadLatency = new HashMap<>();
     private LongAdder writeLatency = new LongAdder();
     private final Map<String, List<RegionTaskResult>> regionMap = new ConcurrentHashMap<>();
+    private Map<ServerName, LongAdder> perServerFailuresCount = new ConcurrentHashMap<>();
 
 Review comment:
   > I mean change `Map<ServerName, LongAddr>` to `ConcurrentMap<ServerName, LongAddr>`, and also for the above `regionMap`. Not a question why you use `ConcurrentHashMap`...
   
   Ok. It's done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services