You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/09/16 19:46:00 UTC
[jira] [Commented] (SOLR-16361) 'mod' function query casts to float, returns wrong modulus for large ints
[ https://issues.apache.org/jira/browse/SOLR-16361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605970#comment-17605970 ]
ASF subversion and git services commented on SOLR-16361:
--------------------------------------------------------
Commit b480bc81ac82094bc5051ace3308a34f85d7604d in solr's branch refs/heads/main from Dan Rosher
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=b480bc81ac8 ]
SOLR-16361 'mod' function query casts to float, returns wrong modulus for large ints (#989)
* use double instead of float
Co-authored-by: Dan Rosher <d....@cv-library.co.uk>
> 'mod' function query casts to float, returns wrong modulus for large ints
> -------------------------------------------------------------------------
>
> Key: SOLR-16361
> URL: https://issues.apache.org/jira/browse/SOLR-16361
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
> Affects Versions: 9.0
> Reporter: Dan Rosher
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> mod function query uses DualFloatFunction. This eventualy does a conversion
> {code:java}
> (float)value {code}
> converting an integer (32bit) into a float which has a 24bit mantissa ,resulting in a loss of precision.
> This means that for integers > 2^24 this returns an incorrect modulus due to this loss of precision.
> Should we use integer only, or perhaps cast to double (so then create a DualDoubleFunction) which has a 52bit mantissa, so can convert int to double without loss of precision?
> This issue may also affect the other function queries?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org