[jira] [Comment Edited] (IGNITE-9519) PK as complex type should can be keep at inline index

["Vladimir Ozerov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612044#comment-16612044 ] 

Vladimir Ozerov edited comment on IGNITE-9519 at 9/12/18 12:19 PM:
-------------------------------------------------------------------

[~slukyanov], [~jooger], 

Folks, the main problem here are tests - they are missing. With this patch we changed internals of our indexes. If something is wrong, we will get lost entries in SELECT statements. Worse, we can get corrupted tree. How do we ensure that this is not the case?

In order to pass review at minimum the following test variations should be added:
 # Composite PK, composite secondary column + plain PK, composite secondary column + composite PK
 # Inline - disabled, in the middle of secondary index, after secondary index, in the middle of PK, after PK
 # Put/remove/put - should work
 # SELECT - equality (WHERE x = ?), range queries, scans
 # CREATE INDEX, rebuild with persistence


was (Author: vozerov):
[~slukyanov], [~jooger],

 

Folks, the main problem here are tests - they are missing. With this patch we changed internals of our indexes. If something is wrong, we will get lost entries in SELECT statements. Worse, we can get corrupted tree. How do we ensure that this is not the case?

In order to pass review at minimum the following test variations should be added:
 # Composite PK, composite secondary column + plain PK, composite secondary column + composite PK
 # Inline - disabled, in the middle of secondary index, after secondary index, in the middle of PK, after PK
 # Put/remove/put - should work
 # SELECT - equality (WHERE x = ?), range queries, scans
 # CREATE INDEX, rebuild with persistence

> PK as complex type should can be keep at inline index
> -----------------------------------------------------
>
>                 Key: IGNITE-9519
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9519
>             Project: Ignite
>          Issue Type: Improvement
>          Components: sql
>    Affects Versions: 2.6
>            Reporter: Yury Gerzhedovich
>            Assignee: Stanislav Lukyanov
>            Priority: Major
>
> Currently in case PK is complex type it can not be keep at inline index.
> This is critical performance issue due to for any put or get operation it cant' be fully comparable and require read full object from the heap or even disk storage.
> To mitigate the problem we need add ability keep complex type (java object) at inline indexes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)