[GitHub] [incubator-druid] gianm commented on a change in pull request #7541: Make JavaScript and XML errors non-TeamCity errors; Update JavaScript language level to ES6 in IntelliJ settings

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #7541: Make JavaScript and XML errors non-TeamCity errors; Update JavaScript language level to ES6 in IntelliJ settings
URL: https://github.com/apache/incubator-druid/pull/7541#discussion_r278208495
 
 

 ##########
 File path: .idea/misc.xml
 ##########
 @@ -69,10 +74,16 @@
           <item index="6" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.qual.NonNull" />
           <item index="7" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullDecl" />
           <item index="8" class="java.lang.String" itemvalue="org.checkerframework.checker.nullness.compatqual.NonNullType" />
+          <item index="9" class="java.lang.String" itemvalue="androidx.annotation.RecentlyNonNull" />
+          <item index="10" class="java.lang.String" itemvalue="com.android.annotations.NonNull" />
         </list>
       </value>
     </option>
   </component>
+  <component name="ProjectResources">
 
 Review comment:
   Due to the fact that these files appear to be copied from elsewhere, I have a some questions about them:
   
   - Why do they need to be added, rather than referenced somehow without copying? (Would make a good comment here)
   - Will there be a need to update them in the future, and if so what would trigger that? Or are these files not expected to update regularly?
   - I don't see a license attached to `assembly-2.0.0.xsd` -- meaning we need to add a comment describing the legal basis for being able to include this file. Ideally this comment takes the form of a statement of what license the file is being used under, and why we believe it falls under that license. Even separately from the legal reason for including a comment, it would be good just to document where the file came from.
   - I do see a license and source URL in a comment at the top of `svg11.dtd`, which is good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org