You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/02 16:02:42 UTC
[GitHub] [beam] fediazgon opened a new pull request #11015: [BEAM-9424]
Allow grouping by LogicalType
fediazgon opened a new pull request #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015
`GROUP BY` statement fails if field is `LogicalType`. E.g., when converting a BQ schema with either `TIME`, `DATE` or `DATETIME` to a Beam schema and grouping by one or more of these fields.
This PR add supports for grouping by LogicalType.
This fixes https://issues.apache.org/jira/browse/BEAM-9424.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov merged pull request #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov merged pull request #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on a change in pull request #11015:
[BEAM-9424] Allow grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on a change in pull request #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#discussion_r386873928
##########
File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java
##########
@@ -373,6 +376,45 @@ public void testNullInnerRow() {
pipeline.run().waitUntilFinish(Duration.standardMinutes(2));
}
+ @Test
+ public void testLogicalTypes() {
+ Schema beamSchemaWithLogicalTypes =
+ BigQueryUtils.fromTableSchema(
Review comment:
Is it possible to use `DummySqlTimeType` and `DummySqlDateType` as in other tests? I find dependency on gcp-io not necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on issue #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on issue #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#issuecomment-593984596
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on issue #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on issue #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#issuecomment-593983612
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on issue #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on issue #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#issuecomment-593979628
Jenkins doesn't build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] fediazgon opened a new pull request #11015: [BEAM-9424]
Allow grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
fediazgon opened a new pull request #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015
`GROUP BY` statement fails if field is `LogicalType`. E.g., when converting a BQ schema with either `TIME`, `DATE` or `DATETIME` to a Beam schema and grouping by one or more of these fields.
This PR add supports for grouping by LogicalType.
This fixes https://issues.apache.org/jira/browse/BEAM-9424.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on issue #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on issue #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#issuecomment-594058397
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on issue #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on issue #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#issuecomment-593836769
R: @kanterov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov closed pull request #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov closed pull request #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on issue #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on issue #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#issuecomment-593984171
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on issue #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on issue #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#issuecomment-593978095
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] kanterov commented on issue #11015: [BEAM-9424] Allow
grouping by LogicalType
Posted by GitBox <gi...@apache.org>.
kanterov commented on issue #11015: [BEAM-9424] Allow grouping by LogicalType
URL: https://github.com/apache/beam/pull/11015#issuecomment-594030815
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services