You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by alopresto <gi...@git.apache.org> on 2018/08/07 03:08:00 UTC

[GitHub] nifi issue #2919: NIFI-5400 - Changed the hostname verifier from the custom ...

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/2919
  
    I merged this but made two changes. First, the `nifi-web-utils` tests were not running, because they are Groovy tests and there is nothing in `src/test/java`. Without a file (even empty) in that directory, the Groovy tests do not get picked up (neither compiled nor run). I added the `groovy-eclipse-compiler` plugin to `nifi-web-utils/pom.xml` to ensure this is run. That commit is [5c0232c](https://github.com/alopresto/nifi/commit/5c0232c9dd8009dc69bc5adb1fb1ef7942832911). 
    
    Second, there was a warning about a duplicate definition of `httpclient` dependency in `nifi-web-utils/pom.xml`. I removed it, and that commit is [5f538c6](https://github.com/alopresto/nifi/commit/5f538c69f1aebc0b6b0d6dbabf0f09c8e9854a57). 
    
    Both of those commits were rebased onto Nathan's rebased commits as well. 
    
    A gist demonstrating the issue is [here](https://gist.github.com/alopresto/184f3631ec44a4c036d323d622ea97aa). 
    
    Ran `contrib-check` and all tests pass. +1, merging. 


---