You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/09/27 13:16:00 UTC

[jira] [Work logged] (AVRO-3042) Make MODEL$ final

     [ https://issues.apache.org/jira/browse/AVRO-3042?focusedWorklogId=655491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655491 ]

ASF GitHub Bot logged work on AVRO-3042:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Sep/21 13:15
            Start Date: 27/Sep/21 13:15
    Worklog Time Spent: 10m 
      Work Description: RyanSkraba commented on pull request #1089:
URL: https://github.com/apache/avro/pull/1089#issuecomment-927864103


   This LGTM but requires updating some test resources in the `lang/java/tools/src/test/compiler/output-string/` and other locations.
   
   This is a really easy thing to do, I'm giving it a test on my fork to get a :heavy_check_mark:  check and I'll merge this manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 655491)
    Remaining Estimate: 0h
            Time Spent: 10m

> Make MODEL$ final
> -----------------
>
>                 Key: AVRO-3042
>                 URL: https://issues.apache.org/jira/browse/AVRO-3042
>             Project: Apache Avro
>          Issue Type: Improvement
>            Reporter: Fokko Driesprong
>            Assignee: Fokko Driesprong
>            Priority: Major
>             Fix For: 1.11.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Each specific record has a reusable static `MODEL$` instance that is configured for that instance.  Changing this instance would likely have only undesirable side effects, so it should be made final.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)