You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by MarkDacek <gi...@git.apache.org> on 2017/03/18 20:02:57 UTC
[GitHub] commons-lang pull request #259: LANG-1167: Add null filter to ReflectionToSt...
GitHub user MarkDacek opened a pull request:
https://github.com/apache/commons-lang/pull/259
LANG-1167: Add null filter to ReflectionToStringBuilder
@chtompki
First attempt at this. In order to avoid a large refactor or breaking existing implementations, the boolean has to be a negative (isExcludeNullValues instead of appendNullValues).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MarkDacek/commons-lang LANG-1167
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
commit 3072c655e0d163f0f38d610c37fd7f3cc727714e
Author: MarkDacek <ma...@richmond.edu>
Date: 2017-03-06T01:36:39Z
This closes #250
commit 40b8ecd3faa8df655ee8b4141ff309553eccfc88
Author: MarkDacek <ma...@richmond.edu>
Date: 2017-03-17T21:43:15Z
Merge remote-tracking branch 'APACHE/master'
commit 661d16d190708a1a396d8b75ba10738e4574c11d
Author: MarkDacek <ma...@richmond.edu>
Date: 2017-03-18T19:47:09Z
LANG-1167: Added isExcludeNullValues to ReflectionToStringBuilder and test
commit 3c2673e82d33b6c9bef3005a896e5b0d52b108dd
Author: MarkDacek <ma...@richmond.edu>
Date: 2017-03-18T20:00:46Z
LANG-1167: Added more test cases for ReflectionToStringBuilderExcludeNullValuesTest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #259: LANG-1167: Add null filter to ReflectionToStringBui...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/259
@chtompki Sorry for the delay, other open source projects and vacations interfered.
As the ToStringStyle implementations are singletons, I do not see a save way to use #209 as a basis for this pull request. Maybe I'm missing something?
I think #209 and this can coexists (as long as the naming is aligned).
@MarkDacek Thanks for creating this pull request. I think it would be great to have this feature in commons-lang. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #259: LANG-1167: Add null filter to ReflectionToStringBui...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/259
[](https://coveralls.io/builds/10664090)
Coverage increased (+0.01%) to 94.559% when pulling **e423b0bc2dea4167ad98fffc1afd9243ba73aad6 on MarkDacek:LANG-1167** into **bf80b9e2803aa277047951a7251267bfb7097c3b on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #259: LANG-1167: Add null filter to ReflectionToStringBui...
Posted by chtompki <gi...@git.apache.org>.
Github user chtompki commented on the issue:
https://github.com/apache/commons-lang/pull/259
@PascalSchumacher - Do you think we should take this approach, or the approach you went after in [LANG-1164](https://issues.apache.org/jira/browse/LANG-1164).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #259: LANG-1167: Add null filter to ReflectionToSt...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---