You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/02/10 00:39:41 UTC
[GitHub] [skywalking] wu-sheng opened a new issue, #10373: Support Java profiling continues when cross thread.
wu-sheng opened a new issue, #10373:
URL: https://github.com/apache/skywalking/issues/10373
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Currently, the profiling targets the endpoint, and ends in current thread and segment only.
We could enhance this to make the profiling flag continues with Snapshot(capture/continue). Therefore, we could have a multi-thread profiling for one endpoint.
### Use case
Typically with more undertow use case, when it doesn't work with SpringMVC, the profiling feature is limited.
Also, for some in memory scheduleling, the current profiling doesn't fit well.
By implementing this enhancement, we should consider enhancing profiling Snapshot to bring thread or segment ID for UI to distinguish threads and merge them with different options.
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] mikechengwei commented on issue #10373: Support Java profiling continues when cross thread.
Posted by "mikechengwei (via GitHub)" <gi...@apache.org>.
mikechengwei commented on issue #10373:
URL: https://github.com/apache/skywalking/issues/10373#issuecomment-1435708073
Can I try to finish this function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10373: Support Java profiling continues when cross thread.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10373:
URL: https://github.com/apache/skywalking/issues/10373#issuecomment-1491345121
https://github.com/apache/skywalking/pull/10613 has merged.
@mrproliu Is this feature ready? If so, let's bring the showcase updated to this latest feature and verify again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10373: Support Java profiling continues when cross thread.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10373:
URL: https://github.com/apache/skywalking/issues/10373#issuecomment-1487866607
@mrproliu When you and @Fine0830 finished all, and the feature is ready on demo.skywalking.a.o, please close here.
I will run 8.15.0 agent side release.
One question, what will happen if agent 8.15 reports multiple profiled segments for the older(< 9.5.0) OAP? Is the old UI still working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] mrproliu commented on issue #10373: Support Java profiling continues when cross thread.
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on issue #10373:
URL: https://github.com/apache/skywalking/issues/10373#issuecomment-1487870422
> One question, what will happen if agent 8.15 reports multiple profiled segments for the older(< 9.5.0) OAP? Is the old UI still working?
In the old UI, it still works, but the name displayed in Segment will be different from the configured endpoint name in Profiling because no merging process has been performed on the displayed segment at this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10373: Support Java profiling continues when cross thread.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10373:
URL: https://github.com/apache/skywalking/issues/10373#issuecomment-1487871387
OK. That should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10373: Support Java profiling continues when cross thread.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10373: Support Java profiling continues when cross thread.
URL: https://github.com/apache/skywalking/issues/10373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org