You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lihaosky (via GitHub)" <gi...@apache.org> on 2025/07/11 02:19:35 UTC

[PR] [FLINK-38068][model] Build uber jar for open-ai model (#26770) [flink]

lihaosky opened a new pull request, #26782:
URL: https://github.com/apache/flink/pull/26782

   Cherry-pick fix https://github.com/apache/flink/commit/c187ebefe7da1d54a2bcef5ecc6f43e86314661e


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38068][model] Build uber jar for open-ai model (#26770) [flink]

Posted by "lihaosky (via GitHub)" <gi...@apache.org>.
lihaosky commented on code in PR #26782:
URL: https://github.com/apache/flink/pull/26782#discussion_r2206020925


##########
flink-models/flink-model-openai/pom.xml:
##########
@@ -39,35 +39,62 @@ under the License.
 		<test.gson.version>2.11.0</test.gson.version>
 	</properties>
 
+	<dependencyManagement>

Review Comment:
   I have a task for it: https://issues.apache.org/jira/browse/FLINK-38084. I guess the doc can only be updated once the jar is published



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38068][model] Build uber jar for open-ai model (#26770) [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26782:
URL: https://github.com/apache/flink/pull/26782#discussion_r2200027380


##########
flink-models/flink-model-openai/pom.xml:
##########
@@ -39,35 +39,62 @@ under the License.
 		<test.gson.version>2.11.0</test.gson.version>
 	</properties>
 
+	<dependencyManagement>

Review Comment:
   Do we need to document this new jar's existence? This could be in a follow-on PR as this seems complete as-is.   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38068][model] Build uber jar for open-ai model (#26770) [flink]

Posted by "lsyldliu (via GitHub)" <gi...@apache.org>.
lsyldliu merged PR #26782:
URL: https://github.com/apache/flink/pull/26782


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38068][model] Build uber jar for open-ai model (#26770) [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26782:
URL: https://github.com/apache/flink/pull/26782#issuecomment-3060046621

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6fb1b0fc3bb49fc62adc7ebea1263a79444c4a1a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6fb1b0fc3bb49fc62adc7ebea1263a79444c4a1a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6fb1b0fc3bb49fc62adc7ebea1263a79444c4a1a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org