[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5175: add pinot upsert features to pinot common
URL: https://github.com/apache/incubator-pinot/pull/5175#discussion_r397361692
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableNameBuilder.java
 ##########
 @@ -132,4 +132,19 @@ public static boolean isOfflineTableResource(String resourceName) {
   public static boolean isRealtimeTableResource(String resourceName) {
     return REALTIME.tableHasTypeSuffix(resourceName);
   }
+
+  /**
+   * ensure that table name ends with type info, if no, create one with the given type
+   * @param tableName the name of the table
+   * @param type the type of the table for it to fill in if the type info is missing
+   * @return the table type name with the type info
+   */
+  public static String ensureTableNameWithType(String tableName, TableType type) {
 
 Review comment:
   Please use `TableNameBuilder.forType(type).tableNameWithType(tableName)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org