You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kamesh Jayachandran <ka...@collab.net> on 2007/05/25 11:03:43 UTC
[PATCH] r25137 causes compile failures if sasl is available
Hi All,
Attached patch fixes the same.
Ran svnserveautocheck observed all PASS.
With regards
Kamesh Jayachandran
Re: [PATCH] r25137 causes compile failures if sasl is available
Posted by "D.J. Heap" <dj...@gmail.com>.
On 5/25/07, Kamesh Jayachandran <ka...@collab.net> wrote:
> Hi All,
>
> Attached patch fixes the same.
>
> Ran svnserveautocheck observed all PASS.
>
Sorry, my fault. I don't have a way to test sasl at the moment, but
this looks good to me. If no one else has any objections, please
commit it.
Thanks!
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] r25137 causes compile failures if sasl is available
Posted by Kamesh Jayachandran <ka...@collab.net>.
> Thanks Kamesh, +1 to commit.
>
>
Thanks Vlad. Fixed in r25147.
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] r25137 causes compile failures if sasl is available
Posted by Vlad Georgescu <vg...@gmail.com>.
Kamesh Jayachandran wrote:
>> Hi Kamesh,
>>
>> I think it's best not to make sasl_pool dependent on the lifetime of the
>> pool that was passed to svn_ra_svn__init. So, instead of revving
>> svn_ra_svn__sasl_init to take a pool parameter, just pass NULL to
>> svn__atomic_init_once.
>>
>> The svnserve changes should be fine, because in that case the pool is
>> long-lived.
>>
>>
>
> Hi Vlad,
>
> Find the attached patch and log. Ran 'make svnserveautocheck', all tests
> pass.
Thanks Kamesh, +1 to commit.
--
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] r25137 causes compile failures if sasl is available
Posted by Kamesh Jayachandran <ka...@collab.net>.
>
> Hi Kamesh,
>
> I think it's best not to make sasl_pool dependent on the lifetime of the
> pool that was passed to svn_ra_svn__init. So, instead of revving
> svn_ra_svn__sasl_init to take a pool parameter, just pass NULL to
> svn__atomic_init_once.
>
> The svnserve changes should be fine, because in that case the pool is
> long-lived.
>
>
Hi Vlad,
Find the attached patch and log. Ran 'make svnserveautocheck', all tests
pass.
With regards
Kamesh Jayachandran
Re: [PATCH] r25137 causes compile failures if sasl is available
Posted by Vlad Georgescu <vg...@gmail.com>.
Kamesh Jayachandran wrote:
> [[[
>
> r25137 breaks sasl builds because of 'svn_atomic__init_once' signature change.
>
> * subversion/include/private/ra_svn_sasl.h
> (svn_ra_svn__sasl_common_init): Accepts 'pool'.
>
> * subversion/libsvn_ra_svn/ra_svn.h
> (svn_ra_svn__sasl_init): Accepts 'pool'.
>
> * subversion/svnserve/server.h
> (cyrus_init): Accepts 'pool'.
>
> * subversion/libsvn_ra_svn/cyrus_auth.c
> (svn_ra_svn__sasl_common_init): Create sasl_pool from the passed in pool.
> (sasl_init_cb): Accepts 'pool'. Passes the pool to
> 'svn_ra_svn__sasl_common_init'
> (svn_ra_svn__sasl_init): Accepts 'pool'. Passes the pool to
> 'svn_atomic__init_once'
>
> * subversion/libsvn_ra_svn/client.c
> (svn_ra_svn__init): Passes 'pool' to 'svn_ra_svn__sasl_init'.
>
Hi Kamesh,
I think it's best not to make sasl_pool dependent on the lifetime of the
pool that was passed to svn_ra_svn__init. So, instead of revving
svn_ra_svn__sasl_init to take a pool parameter, just pass NULL to
svn__atomic_init_once.
The svnserve changes should be fine, because in that case the pool is
long-lived.
--
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org