You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/02/17 21:16:40 UTC
[GitHub] [libcloud] Kami opened a new pull request #1430: Fix
LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE functionality under Python 3
Kami opened a new pull request #1430: Fix LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE functionality under Python 3
URL: https://github.com/apache/libcloud/pull/1430
This pull request fixes logging connection so ``LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE`` functionality works correctly under Python 3.
It also adds some test cases for that functionality (previously we had none).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1430: Fix
LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE functionality under Python 3
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1430: Fix LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE functionality under Python 3
URL: https://github.com/apache/libcloud/pull/1430#issuecomment-587165604
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1430?src=pr&el=h1) Report
> Merging [#1430](https://codecov.io/gh/apache/libcloud/pull/1430?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/9e51fc06e79a32f43d513d815b12e8a8f834d269?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/libcloud/pull/1430?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1430 +/- ##
==========================================
+ Coverage 86.08% 86.11% +0.02%
==========================================
Files 370 370
Lines 77507 77554 +47
Branches 7655 7656 +1
==========================================
+ Hits 66724 66782 +58
+ Misses 7884 7876 -8
+ Partials 2899 2896 -3
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1430?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/utils/loggingconnection.py](https://codecov.io/gh/apache/libcloud/pull/1430/diff?src=pr&el=tree#diff-bGliY2xvdWQvdXRpbHMvbG9nZ2luZ2Nvbm5lY3Rpb24ucHk=) | `76.31% <100%> (+14.47%)` | :arrow_up: |
| [libcloud/test/test\_logging\_connection.py](https://codecov.io/gh/apache/libcloud/pull/1430/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC90ZXN0X2xvZ2dpbmdfY29ubmVjdGlvbi5weQ==) | `100% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1430?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1430?src=pr&el=footer). Last update [9e51fc0...c3674f3](https://codecov.io/gh/apache/libcloud/pull/1430?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1430: Fix
LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE functionality under Python 3
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1430: Fix LIBCLOUD_DEBUG_PRETTY_PRINT_RESPONSE functionality under Python 3
URL: https://github.com/apache/libcloud/pull/1430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services