You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "2010YOUY01 (via GitHub)" <gi...@apache.org> on 2024/09/07 03:22:48 UTC

[I] Optimize `lower()/upper()` string function with ASCII fast path [datafusion]

2010YOUY01 opened a new issue, #12365:
URL: https://github.com/apache/datafusion/issues/12365

   ### Is your feature request related to a problem or challenge?
   
   Part of https://github.com/apache/datafusion/issues/12306
   
   https://github.com/apache/datafusion/issues/12306 has introduced the rationale for ASCII fast path in detail
   
   This optimization has already been implemented on `char_length()` string function and got some performance improvement
   (In PR https://github.com/apache/datafusion/pull/12356)
   
   
   ### Describe the solution you'd like
   
   Implement ASCII fast path for `lower()` and `upper()` function
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Optimize `lower()/upper()` string function with ASCII fast path [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #12365:
URL: https://github.com/apache/datafusion/issues/12365#issuecomment-3707042707

   This seems done by
   
   - #9971


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Optimize `lower()/upper()` string function with ASCII fast path [datafusion]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed issue #12365: Optimize `lower()/upper()` string function with ASCII fast path
URL: https://github.com/apache/datafusion/issues/12365


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Optimize `lower()/upper()` string function with ASCII fast path [datafusion]

Posted by "tshauck (via GitHub)" <gi...@apache.org>.
tshauck commented on issue #12365:
URL: https://github.com/apache/datafusion/issues/12365#issuecomment-2335046808

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Optimize `lower()/upper()` string function with ASCII fast path [datafusion]

Posted by "thinh2 (via GitHub)" <gi...@apache.org>.
thinh2 commented on issue #12365:
URL: https://github.com/apache/datafusion/issues/12365#issuecomment-2403635332

   thanks @tshauck . Let me try to do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Optimize `lower()/upper()` string function with ASCII fast path [datafusion]

Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #12365:
URL: https://github.com/apache/datafusion/issues/12365#issuecomment-2465468703

   Note that lower/upper likely already does this. See https://github.com/apache/datafusion/blob/f190fc6de6a6171c1cd6aa99233bc647ed8b1377/datafusion/functions/src/string/common.rs#L377 and https://github.com/apache/datafusion/blob/f190fc6de6a6171c1cd6aa99233bc647ed8b1377/datafusion/functions/src/string/common.rs#L400


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org