[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18444: Revert "Fix task instance url in webserver utils"

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #18444:
URL: https://github.com/apache/airflow/pull/18444#discussion_r714282887



##########
File path: airflow/www/utils.py
##########
@@ -228,7 +228,7 @@ def task_instance_link(attr):
     dag_id = attr.get('dag_id')
     task_id = attr.get('task_id')
     execution_date = attr.get('dag_run.execution_date') or attr.get('execution_date') or timezone.utcnow()
-    url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id, execution_date=execution_date)
+    url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id)

Review comment:
       ```suggestion
       url = url_for('Airflow.task', dag_id=dag_id, task_id=task_id,  execution_date=execution_date.isoformat())
   ```
   This suggestion was not applied, I had thought I applied it, surprised that I didn't. https://github.com/apache/airflow/pull/18418#discussion_r713520604




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org