You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by pr...@apache.org on 2005/11/19 01:20:03 UTC

svn commit: r345604 - /myfaces/sandbox/trunk/src/java/org/apache/myfaces/custom/ajax/util/AjaxRendererUtils.java

Author: prophecy
Date: Fri Nov 18 16:19:53 2005
New Revision: 345604

URL: http://svn.apache.org/viewcvs?rev=345604&view=rev
Log:
- was setting the message id wrong so wasn't working with multiple message tags on the same page, fixed
- now it will also clear the error message on success

Modified:
    myfaces/sandbox/trunk/src/java/org/apache/myfaces/custom/ajax/util/AjaxRendererUtils.java

Modified: myfaces/sandbox/trunk/src/java/org/apache/myfaces/custom/ajax/util/AjaxRendererUtils.java
URL: http://svn.apache.org/viewcvs/myfaces/sandbox/trunk/src/java/org/apache/myfaces/custom/ajax/util/AjaxRendererUtils.java?rev=345604&r1=345603&r2=345604&view=diff
==============================================================================
--- myfaces/sandbox/trunk/src/java/org/apache/myfaces/custom/ajax/util/AjaxRendererUtils.java (original)
+++ myfaces/sandbox/trunk/src/java/org/apache/myfaces/custom/ajax/util/AjaxRendererUtils.java Fri Nov 18 16:19:53 2005
@@ -125,27 +125,39 @@
                 .append("       var elvalue = myObElement.getAttribute(\"elvalue\");\n")
                 .append("       if (successful)\n")
                 .append("       {\n");
-        if (component.getOnSuccess() != null)
+        if (component.getOnSuccess() != null) {
             buff.append("        ").append(jsNameSpace).append("onSuccessFunction(elname, elvalue);\n");
+        }
+        buff.append("        ").append(jsNameSpace).append("clearError(elname);\n");
         buff.append("    }\n")
                 .append("        else\n")
                 .append("        {\n");
         if (component.getOnFailure() != null)
             buff.append("        ").append(jsNameSpace).append("onFailureFunction(elname, elvalue);\n");
         buff.append("        }\n").append("     }\n").append("}\n");
-        buff.append("function ").append(jsNameSpace)
-                .append("displayError(elname, severity, summary, styleClass, style){\n")
+
+        // displayError function shows any errors sent back
+        buff.append("function ").append(jsNameSpace).append("displayError(elname, severity, summary, styleClass, style){\n")
                 .append("    var msgSpan = document.getElementById(\"msgFor_\" + elname);\n")
                 .append("    if(msgSpan){\n")
                 .append("        msgSpan.innerHTML = summary;\n")
-                .append("        if(styleClass) msgSpan.className = styleClass;")
+                .append("        if(styleClass) msgSpan.className = styleClass;\n")
                 //.append("        if(style) msgSpan.style = style;") // guess you can't swap out the entire style like this
                 .append("    }\n")
                 .append("}\n");
+        // clearError function to remove error display if there was one previously
+        buff.append("function ").append(jsNameSpace).append("clearError(elname){\n")
+                .append("    var msgSpan = document.getElementById(\"msgFor_\" + elname);\n")
+                .append("    if(msgSpan){\n")
+                .append("        msgSpan.innerHTML = \"\";\n")
+                .append("    }\n")
+                .append("}\n");
+
         buff.append("function ").append(jsNameSpace)
                 .append("notifyElementFailure(originalRequest){\n")
                 .append("    ").append(jsNameSpace)
                 .append("notifyElement(originalRequest, false);\n" + "}\n");
+
         buff.append("function ").append(jsNameSpace)
                 .append("notifyElementSuccess(originalRequest){\n")
                 .append("    ").append(jsNameSpace)